[Bug target/108411] New: [13 Regression] ICEs in aarch64_layout_arg

[Bug target/108411] New: [13 Regression] ICEs in aarch64_layout_arg

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108411

            Bug ID: 108411
           Summary: [13 Regression] ICEs in aarch64_layout_arg
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: jakub at gcc dot gnu.org
  Target Milestone: ---

r13-5124-g6610daa1cfb75b72500c2
introduced some ICEs:
+FAIL: gcc.target/aarch64/sve/pcs/struct_3_128.c -march=armv8.2-a+sve (internal
compiler error: in aarch64_layout_arg, at config/aarch64/aarch64.cc:7696)       
+FAIL: gcc.target/aarch64/sve/pcs/struct_3_128.c -march=armv8.2-a+sve (test for
excess errors)                                                                  
+FAIL: gcc.target/aarch64/sve/pcs/struct_3_256.c -march=armv8.2-a+sve (internal
compiler error: in aarch64_layout_arg, at config/aarch64/aarch64.cc:7696)       
+FAIL: gcc.target/aarch64/sve/pcs/struct_3_256.c -march=armv8.2-a+sve (test for
excess errors)                                                                  
+FAIL: gcc.target/aarch64/sve/pcs/struct_3_512.c -march=armv8.2-a+sve (internal
compiler error: in aarch64_layout_arg, at config/aarch64/aarch64.cc:7696)       
+FAIL: gcc.target/aarch64/sve/pcs/struct_3_512.c -march=armv8.2-a+sve (test for
excess errors)                                                                  
as well as (with -fstack-protector-all)
+FAIL: g++.target/aarch64/bitfield-abi-warning-align16-O2.C
scan-assembler-times and\\tw0, w1, 1 10                                         
+FAIL: g++.target/aarch64/bitfield-abi-warning-align32-O2.C
scan-assembler-times and\\tw0, w1, 1 10                                         
+FAIL: g++.target/aarch64/bitfield-abi-warning-align8-O2.C scan-assembler-times
and\\tw0, w0, 1 11                                                              
+FAIL: g++.target/aarch64/bitfield-abi-warning-align8-O2.C scan-assembler-times
and\\tw0, w1, 1 18                                                              
regressions.
For the latter (can be seen e.g. when configured --enable-default-ssp or when
testing with RUNTESTFLAGS=--target_board=unix/-fstack-protector-all) I think
just adding explicit -fno-stack-protector to the test would be enough.
The former can be reduced e.g. to

typedef __SVInt32_t fixed_int32_t __attribute__ ((arm_sve_vector_bits (128)));  
struct A { fixed_int32_t a[3] __attribute__((aligned((128 / 8) * 2))); };       
void foo (struct A x) {}                                                        

with -march=armv8.2-a+sve -O -msve-vector-bits=128
I wonder if just the assertion shouldn't be dropped, user alignment can be
arbitrarily large.

[Bug target/108411] [13 Regression] ICEs in aarch64_layout_arg

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108411

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
                 CC|                            |clyon at gcc dot gnu.org
   Target Milestone|---                         |13.0
   Last reconfirmed|                            |2023-01-15
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

[Bug target/108411] [13 Regression] ICEs in aarch64_layout_arg

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108411

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Christophe Lyon <clyon@gcc.gnu.org>:

https://gcc.gnu.org/g:a38c079248411ea9dc0610873b3366192315bfee

commit r13-5256-ga38c079248411ea9dc0610873b3366192315bfee
Author: Christophe Lyon <christophe.lyon@arm.com>
Date:   Mon Jan 16 17:48:25 2023 +0000

    aarch64: fix ICE in aarch64_layout_arg [PR108411]

    The previous patch added an assert which should not be applied to PST
    types (Pure Scalable Types) because alignment does not matter in this
    case.  This patch moves the assert after the PST case is handled to
    avoid the ICE.

            PR target/108411
            gcc/
            * config/aarch64/aarch64.cc (aarch64_layout_arg): Improve
            comment. Move assert about alignment a bit later.

[Bug target/108411] [13 Regression] ICEs in aarch64_layout_arg

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108411

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Christophe Lyon <clyon@gcc.gnu.org>:

https://gcc.gnu.org/g:74833b3165865a9373506f447720cf20f29c20c8

commit r13-5257-g74833b3165865a9373506f447720cf20f29c20c8
Author: Christophe Lyon <christophe.lyon@arm.com>
Date:   Tue Jan 17 13:10:10 2023 +0000

    aarch64: add -fno-stack-protector to some tests [PR108411]

    As discussed in the PR, these recently added tests fail when the
    testsuite is executed with -fstack-protector-strong.  To avoid this,
    this patch adds -fno-stack-protector to dg-options.

            PR target/108411
            gcc/testsuite
            * g++.target/aarch64/bitfield-abi-warning-align16-O2-extra.C: Add
            -fno-stack-protector.
            * g++.target/aarch64/bitfield-abi-warning-align16-O2.C: Likewise.
            * g++.target/aarch64/bitfield-abi-warning-align32-O2-extra.C:
Likewise.
            * g++.target/aarch64/bitfield-abi-warning-align32-O2.C: Likewise.
            * g++.target/aarch64/bitfield-abi-warning-align8-O2.C: Likewise.
            * gcc.target/aarch64/bitfield-abi-warning-align16-O2-extra.c:
Likewise.
            * gcc.target/aarch64/bitfield-abi-warning-align16-O2.c: Likewise.
            * gcc.target/aarch64/bitfield-abi-warning-align32-O2-extra.c:
Likewise.
            * gcc.target/aarch64/bitfield-abi-warning-align32-O2.c: Likewise.
            * gcc.target/aarch64/bitfield-abi-warning-align8-O2.c: Likewise.

[Bug target/108411] [13 Regression] ICEs in aarch64_layout_arg

[clyon at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108411

Christophe Lyon <clyon at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Christophe Lyon <clyon at gcc dot gnu.org> ---
Fixed.