* [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98
2023-01-16 17:46 [Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 gscfq@t-online.de
@ 2023-01-16 19:41 ` anlauf at gcc dot gnu.org
2023-01-16 20:14 ` anlauf at gcc dot gnu.org
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2023-01-16 19:41 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anlauf at gcc dot gnu.org
Status|UNCONFIRMED |NEW
Last reconfirmed| |2023-01-16
Ever confirmed|0 |1
--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.
The following variation actually ICEs for me down to at least v7:
program p
character :: c = 'c'
logical :: m = .true.
print *, merge(transfer('a', 'b', 0), c, m)
end
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98
2023-01-16 17:46 [Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 gscfq@t-online.de
2023-01-16 19:41 ` [Bug fortran/108420] " anlauf at gcc dot gnu.org
@ 2023-01-16 20:14 ` anlauf at gcc dot gnu.org
2023-01-16 21:13 ` anlauf at gcc dot gnu.org
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2023-01-16 20:14 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420
--- Comment #2 from anlauf at gcc dot gnu.org ---
I'm regtesting the following patch which fixes both cases:
diff --git a/gcc/fortran/iresolve.cc b/gcc/fortran/iresolve.cc
index 711e9178ad4..33794f0a858 100644
--- a/gcc/fortran/iresolve.cc
+++ b/gcc/fortran/iresolve.cc
@@ -94,9 +94,12 @@ check_charlen_present (gfc_expr *source)
else if (source->expr_type == EXPR_ARRAY)
{
gfc_constructor *c = gfc_constructor_first (source->value.constructor);
- source->ts.u.cl->length
- = gfc_get_int_expr (gfc_charlen_int_kind, NULL,
- c->expr->value.character.length);
+ if (c)
+ source->ts.u.cl->length
+ = gfc_get_int_expr (gfc_charlen_int_kind, NULL,
+ c->expr->value.character.length);
+ if (source->ts.u.cl->length == NULL)
+ gfc_internal_error ("check_charlen_present(): length not set");
}
}
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98
2023-01-16 17:46 [Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 gscfq@t-online.de
2023-01-16 19:41 ` [Bug fortran/108420] " anlauf at gcc dot gnu.org
2023-01-16 20:14 ` anlauf at gcc dot gnu.org
@ 2023-01-16 21:13 ` anlauf at gcc dot gnu.org
2023-01-17 7:04 ` rguenth at gcc dot gnu.org
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2023-01-16 21:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |anlauf at gcc dot gnu.org
Status|NEW |ASSIGNED
--- Comment #3 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2023-January/058774.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98
2023-01-16 17:46 [Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 gscfq@t-online.de
` (2 preceding siblings ...)
2023-01-16 21:13 ` anlauf at gcc dot gnu.org
@ 2023-01-17 7:04 ` rguenth at gcc dot gnu.org
2023-01-17 13:28 ` [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b marxin at gcc dot gnu.org
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-01-17 7:04 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P4
Target Milestone|--- |13.0
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b
2023-01-16 17:46 [Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 gscfq@t-online.de
` (3 preceding siblings ...)
2023-01-17 7:04 ` rguenth at gcc dot gnu.org
@ 2023-01-17 13:28 ` marxin at gcc dot gnu.org
2023-01-23 19:16 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: marxin at gcc dot gnu.org @ 2023-01-17 13:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420
Martin Liška <marxin at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marxin at gcc dot gnu.org
Summary|[13 Regression] ICE in |[13 Regression] ICE in
|check_charlen_present, at |check_charlen_present, at
|fortran/iresolve.cc:98 |fortran/iresolve.cc:98
| |since
| |r13-4394-g3832c6f7e672e76b
--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
Started with r13-4394-g3832c6f7e672e76b.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b
2023-01-16 17:46 [Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 gscfq@t-online.de
` (4 preceding siblings ...)
2023-01-17 13:28 ` [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b marxin at gcc dot gnu.org
@ 2023-01-23 19:16 ` cvs-commit at gcc dot gnu.org
2023-01-28 21:45 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-01-23 19:16 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420
--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:e6669c0a50ed8aee9e5997d61e6271668d149218
commit r13-5311-ge6669c0a50ed8aee9e5997d61e6271668d149218
Author: Harald Anlauf <anlauf@gmx.de>
Date: Mon Jan 16 21:41:09 2023 +0100
Fortran: fix ICE in check_charlen_present [PR108420]
gcc/fortran/ChangeLog:
PR fortran/108420
* iresolve.cc (check_charlen_present): Preserve character length if
there is no array constructor.
gcc/testsuite/ChangeLog:
PR fortran/108420
* gfortran.dg/pr108420.f90: New test.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b
2023-01-16 17:46 [Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 gscfq@t-online.de
` (5 preceding siblings ...)
2023-01-23 19:16 ` cvs-commit at gcc dot gnu.org
@ 2023-01-28 21:45 ` cvs-commit at gcc dot gnu.org
2023-02-04 15:43 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-01-28 21:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420
--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:523ee9f5994961b27c61d46b27dbe064f68d0d76
commit r12-9077-g523ee9f5994961b27c61d46b27dbe064f68d0d76
Author: Harald Anlauf <anlauf@gmx.de>
Date: Mon Jan 16 21:41:09 2023 +0100
Fortran: fix ICE in check_charlen_present [PR108420]
gcc/fortran/ChangeLog:
PR fortran/108420
* iresolve.cc (check_charlen_present): Preserve character length if
there is no array constructor.
gcc/testsuite/ChangeLog:
PR fortran/108420
* gfortran.dg/pr108420.f90: New test.
(cherry picked from commit e6669c0a50ed8aee9e5997d61e6271668d149218)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b
2023-01-16 17:46 [Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 gscfq@t-online.de
` (6 preceding siblings ...)
2023-01-28 21:45 ` cvs-commit at gcc dot gnu.org
@ 2023-02-04 15:43 ` cvs-commit at gcc dot gnu.org
2023-02-05 18:55 ` cvs-commit at gcc dot gnu.org
2023-02-05 18:58 ` anlauf at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-02-04 15:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420
--- Comment #7 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:c3985fd624053502b0aad85132982b4f8970811a
commit r11-10501-gc3985fd624053502b0aad85132982b4f8970811a
Author: Harald Anlauf <anlauf@gmx.de>
Date: Mon Jan 16 21:41:09 2023 +0100
Fortran: fix ICE in check_charlen_present [PR108420]
gcc/fortran/ChangeLog:
PR fortran/108420
* iresolve.c (check_charlen_present): Preserve character length if
there is no array constructor.
gcc/testsuite/ChangeLog:
PR fortran/108420
* gfortran.dg/pr108420.f90: New test.
(cherry picked from commit e6669c0a50ed8aee9e5997d61e6271668d149218)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b
2023-01-16 17:46 [Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 gscfq@t-online.de
` (7 preceding siblings ...)
2023-02-04 15:43 ` cvs-commit at gcc dot gnu.org
@ 2023-02-05 18:55 ` cvs-commit at gcc dot gnu.org
2023-02-05 18:58 ` anlauf at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-02-05 18:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420
--- Comment #8 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:
https://gcc.gnu.org/g:b14dcf0c99fab065e11ec87984475580b649edeb
commit r10-11193-gb14dcf0c99fab065e11ec87984475580b649edeb
Author: Harald Anlauf <anlauf@gmx.de>
Date: Mon Jan 16 21:41:09 2023 +0100
Fortran: fix ICE in check_charlen_present [PR108420]
gcc/fortran/ChangeLog:
PR fortran/108420
* iresolve.c (check_charlen_present): Preserve character length if
there is no array constructor.
gcc/testsuite/ChangeLog:
PR fortran/108420
* gfortran.dg/pr108420.f90: New test.
(cherry picked from commit e6669c0a50ed8aee9e5997d61e6271668d149218)
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Bug fortran/108420] [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 since r13-4394-g3832c6f7e672e76b
2023-01-16 17:46 [Bug fortran/108420] New: [13 Regression] ICE in check_charlen_present, at fortran/iresolve.cc:98 gscfq@t-online.de
` (8 preceding siblings ...)
2023-02-05 18:55 ` cvs-commit at gcc dot gnu.org
@ 2023-02-05 18:58 ` anlauf at gcc dot gnu.org
9 siblings, 0 replies; 11+ messages in thread
From: anlauf at gcc dot gnu.org @ 2023-02-05 18:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108420
anlauf at gcc dot gnu.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Target Milestone|13.0 |10.5
--- Comment #9 from anlauf at gcc dot gnu.org ---
Fixed on all open branches. Closing.
Thanks for the report!
^ permalink raw reply [flat|nested] 11+ messages in thread