From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 8CF69385B53C; Mon,  3 Apr 2023 08:57:44 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8CF69385B53C
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1680512264;
	bh=JbdyMdIQciP/5wzQd6evr2TDGXYLwNiBnx27CzfnC9Y=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=aVT49dCX6cIXlbIe8gnFMNJwTJNCPFNvrnww79jqM91+yGYAi/67idLMHhT82AiuB
	 NAdeh0abiZuxQTb5rtStzquQUpOLX4uUGPlVxWae3sDaaRg3kwvvilMLG4AfQrZ16F
	 MYlT7EBKvJwExQZLQGSdZ+goW6QYaErEx5gcEd3k=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/108430] [12 Regression] Wrong code with
 -msve-vector-bits=512 since r13-707-g68e0063397
Date: Mon, 03 Apr 2023 08:57:44 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: rsandifo at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108430-4-y8Z5jzVBm5@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108430-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108430-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108430

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Richard Sandiford
<rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:33a69d0b0b772610463d1d586f3f0c9820fc969e

commit r12-9378-g33a69d0b0b772610463d1d586f3f0c9820fc969e
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Mon Apr 3 09:57:06 2023 +0100

    vect: Fix voluntarily-masked negative conditionals [PR108430]

    vectorizable_condition checks whether a COND_EXPR condition is used
    elsewhere with a loop mask.  If so, it applies the loop mask to the
    COND_EXPR too, to reduce the number of live masks and to increase the
    chance of combining the AND with the comparison.

    There is also code to do this for inverted conditions.  E.g. if
    we have a < b ? c : d and something else is conditional on !(a < b)
    (such as a load in d), we use !(a < b) ? d : c and apply the loop
    mask to !(a < b).

    This inversion relied on the function's bitop1/bitop2 mechanism.
    However, that mechanism is skipped if the condition is split out of
    the COND_EXPR as a separate statement.  This meant that we could end
    up using the inverse of the intended condition.

    There is a separate way of negating the condition when a mask
    is being applied (which is also used for EXTRACT_LAST reductions).
    This patch uses that instead.

    As well as the testcase, this fixes aarch64/sve/vcond_{4,17}_run.c.

    gcc/
            PR tree-optimization/108430
            * tree-vect-stmts.cc (vectorizable_condition): Fix handling
            of inverted condition.

    gcc/testsuite/
            PR tree-optimization/108430
            * gcc.target/aarch64/sve/pr108430.c: New test.

    (cherry picked from commit 2a8ce4b52f5892a10a02b94d7be689e59a444ff6)=