From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 3FDEC3858CDB; Thu,  2 Mar 2023 10:30:37 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3FDEC3858CDB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1677753037;
	bh=5mYG7qAGfpadWCNAQp5nRNV6FNSGLtnpJQyOmRFDSmw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=xcOJyNc1hnRau3LmRgYRb2Ow4KSXAzlGsSeJ/BQtqWC8umVUJhJvt/r1ck5fczFj0
	 tb6jvfgV1Rvwci4Zx1OfDlh7oc2v/laO2JGWw1xix7bL5qq/FFVxZflTyLiJYADSD0
	 JYS3Chx/wuVu3PlolIu19oyS/Df0FamVjYBljqIg=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/108430] [13 Regression] Wrong code with
 -msve-vector-bits=512 since r13-707-g68e0063397
Date: Thu, 02 Mar 2023 10:30:35 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: rsandifo at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108430-4-yMMfIRnvFf@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108430-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108430-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108430

--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.or=
g>:

https://gcc.gnu.org/g:2a8ce4b52f5892a10a02b94d7be689e59a444ff6

commit r13-6409-g2a8ce4b52f5892a10a02b94d7be689e59a444ff6
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Thu Mar 2 10:30:20 2023 +0000

    vect: Fix voluntarily-masked negative conditionals [PR108430]

    vectorizable_condition checks whether a COND_EXPR condition is used
    elsewhere with a loop mask.  If so, it applies the loop mask to the
    COND_EXPR too, to reduce the number of live masks and to increase the
    chance of combining the AND with the comparison.

    There is also code to do this for inverted conditions.  E.g. if
    we have a < b ? c : d and something else is conditional on !(a < b)
    (such as a load in d), we use !(a < b) ? d : c and apply the loop
    mask to !(a < b).

    This inversion relied on the function's bitop1/bitop2 mechanism.
    However, that mechanism is skipped if the condition is split out of
    the COND_EXPR as a separate statement.  This meant that we could end
    up using the inverse of the intended condition.

    There is a separate way of negating the condition when a mask
    is being applied (which is also used for EXTRACT_LAST reductions).
    This patch uses that instead.

    As well as the testcase, this fixes aarch64/sve/vcond_{4,17}_run.c.

    gcc/
            PR tree-optimization/108430
            * tree-vect-stmts.cc (vectorizable_condition): Fix handling
            of inverted condition.

    gcc/testsuite/
            PR tree-optimization/108430
            * gcc.target/aarch64/sve/pr108430.c: New test.=