public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/108435] [13 Regression] ICE in as_a, at is-a.h:242 since r13-142-g705bcedf6eae2d7c
Date: Wed, 01 Feb 2023 14:24:50 +0000	[thread overview]
Message-ID: <bug-108435-4-q5UhBJ1T6I@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108435-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108435

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I think the problem is that normally when gimplifying
OMP_CLAUSE_LASTPRIVATE_STMT we force a BIND_EXPR around it:
              push_gimplify_context ();
              if (TREE_CODE (OMP_CLAUSE_LASTPRIVATE_STMT (c)) != BIND_EXPR)
                {
                  tree bind = build3 (BIND_EXPR, void_type_node, NULL,
                                      NULL, NULL);
                  TREE_SIDE_EFFECTS (bind) = 1;
                  BIND_EXPR_BODY (bind) = OMP_CLAUSE_LASTPRIVATE_STMT (c);
                  OMP_CLAUSE_LASTPRIVATE_STMT (c) = bind;
                }
              gimplify_and_add (OMP_CLAUSE_LASTPRIVATE_STMT (c),
                                &OMP_CLAUSE_LASTPRIVATE_GIMPLE_SEQ (c));
              pop_gimplify_context
                (gimple_seq_first_stmt (OMP_CLAUSE_LASTPRIVATE_GIMPLE_SEQ
(c)));
(similarly for linear), but in this case we do it only conditionally - if
temporaries are needed:
                if (OMP_CLAUSE_CODE (c) == OMP_CLAUSE_LASTPRIVATE)
                  seq = &OMP_CLAUSE_LASTPRIVATE_GIMPLE_SEQ (c);
                else
                  seq = &OMP_CLAUSE_LINEAR_GIMPLE_SEQ (c);
                push_gimplify_context ();
                gimplify_assign (decl, t, seq);
                gimple *bind = NULL;
                if (gimplify_ctxp->temps)
                  {
                    bind = gimple_build_bind (NULL_TREE, *seq, NULL_TREE);
                    *seq = NULL;
                    gimplify_seq_add_stmt (seq, bind);
                  }
                pop_gimplify_context (bind);
So, either we do it also unconditionally during gimplify.cc, or in
tree-nested.cc add it later.

  parent reply	other threads:[~2023-02-01 14:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-17 17:47 [Bug fortran/108435] New: [13 Regression] ICE in as_a, at is-a.h:242 gscfq@t-online.de
2023-01-18  8:48 ` [Bug fortran/108435] [13 Regression] ICE in as_a, at is-a.h:242 since r13-142-g705bcedf6eae2d7c marxin at gcc dot gnu.org
2023-01-18  8:58 ` rguenth at gcc dot gnu.org
2023-01-19 12:33 ` jakub at gcc dot gnu.org
2023-01-20 17:23 ` [Bug middle-end/108435] " burnus at gcc dot gnu.org
2023-02-01 14:24 ` jakub at gcc dot gnu.org [this message]
2023-02-01 15:29 ` jakub at gcc dot gnu.org
2023-02-02  8:59 ` cvs-commit at gcc dot gnu.org
2023-02-03 13:57 ` jakub at gcc dot gnu.org
2023-02-10 17:46 ` cvs-commit at gcc dot gnu.org
2023-05-02 20:14 ` cvs-commit at gcc dot gnu.org
2023-05-03 15:21 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108435-4-q5UhBJ1T6I@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).