From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 049B23858C62; Fri, 20 Jan 2023 15:24:34 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 049B23858C62
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1674228275;
	bh=phYpri9JSaXDjpktuZD7IIECyXL5K7NmGRpPYQwCcdo=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=sP/YKjLS7HKfQJpCQdYSi3pCbkl9iSShWURSUHnaWNgOqFl3ANJhzlH8IxFHJY5rr
	 rXkP6C/OWGB3nJUVxTKpYcyli9N0SoaWUHx3woeT+1sLegTnmCGvCnGFa7FAnoCNCv
	 IB/uvtRceAFuTXfwPkipr04kOHu1H2TT2+ygd/RE=
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/108447] [13 Regression] glibc
 math/test-*-iseqsig failures
Date: Fri, 20 Jan 2023 15:24:32 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: missed-optimization, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jakub at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108447-4-dGP5GgCtTc@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108447-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108447-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108447

--- Comment #21 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Andrew Macleod from comment #19)
> Created attachment 54313 [details]
> better patch
>=20
> A more consistent approach.. rather than directly call relation_intersect=
()
> from multiple places, add the floating point fix to
> value_relation::intersect and always go through that.
>=20
> This will cause the normal oracle and the path oracle to both make the
> previous adjustment to intersect for floating point operations.   unteste=
d,
> running tests now.

I thought (unless somebody proves otherwise) that relation_intersect is
actually just fine, the only thing that is incorrect (IMHO) for floating po=
int
with NaNs are the
relation_union (VREL_L[TE], VREL_G[TE]) and relation_union (VREL_G[TE],
VREL_L[TE])
cases, because those return VREL_NE or VREL_VARYING even when those are
actually
LTGT_EXPR (aka ordered and not equal) or ORDERED_EXPR.
So, if the callers of relation_union know whether it is a relation for floa=
ting
point with NAN or integral/pointer/floating point fast math can't they just
tweak those cases?=