public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/108448] GCC Elides Assignment to Pointer and memcpy
Date: Thu, 19 Jan 2023 06:03:53 +0000	[thread overview]
Message-ID: <bug-108448-4-2zp6iOLazD@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108448-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108448

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I do notice some aliasing violations with y_map_index and
y_strucon_handleErrorHelper


 y_vec* stack;
...
      y_map_existsStringKey_v(d->contexts, ("com.yzena.yc.error_handler"),
                              &stack))
...

y_map_existsStringKey_v takes a void* and passes it to:
 ret = (y_map_index(m, &str,
# 896 "yc/src/container/map.c" 3 4
                            ((void *)0)
# 896 "yc/src/container/map.c"
                                , val_ptr) != ((y_usize) -1));


While y_map_index's last argument is y_uchar** and you do the store as y_uchar*
inside y_map_index:
   *val_ptr = ((m)->map[(arrayIdx)] + (itemIdx) * (m->esize));

------ CUT -----

I suspect cmake didn't add -fno-strict-aliasing really.

Can you try:
   *(void**)val_ptr = ((m)->map[(arrayIdx)] + (itemIdx) * (m->esize));


Note GCC extends aliasing here where "void*" is treated similarly as a
character type with respect to aliasing.

  parent reply	other threads:[~2023-01-19  6:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 18:09 [Bug c/108448] New: " gavin at yzena dot com
2023-01-18 18:15 ` [Bug c/108448] " pinskia at gcc dot gnu.org
2023-01-18 18:16 ` [Bug middle-end/108448] " pinskia at gcc dot gnu.org
2023-01-18 18:22 ` gavin at yzena dot com
2023-01-18 18:29 ` pinskia at gcc dot gnu.org
2023-01-18 18:44 ` gavin at yzena dot com
2023-01-19  5:51 ` gavin at yzena dot com
2023-01-19  6:03 ` pinskia at gcc dot gnu.org [this message]
2023-01-19 15:29 ` gavin at yzena dot com
2023-01-19 15:36 ` gavin at yzena dot com
2023-01-23 22:33 ` gavin at yzena dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108448-4-2zp6iOLazD@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).