public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/108463] [13 Regression] ICE: in cselib_subst_to_values, at cselib.cc:2148 with -O2 -fsched2-use-superblocks -g
Date: Thu, 26 Jan 2023 20:00:50 +0000 [thread overview]
Message-ID: <bug-108463-4-09gjGXCPP7@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108463-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108463
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I've now tried:
--- sched-deps.cc.jj7 2023-01-19 09:58:50.971227752 +0100
+++ sched-deps.cc 2023-01-26 20:58:30.036035079 +0100
@@ -2498,7 +2498,10 @@ sched_analyze_1 (class deps_desc *deps,
pending_mem = deps->pending_read_mems;
while (pending)
{
- if (anti_dependence (pending_mem->element (), t)
+bool b = anti_dependence (pending_mem->element (), t);
+if (sched_deps_info->use_cselib && !DEBUG_INSN_P (insn) && !DEBUG_INSN_P
(pending->insn ()))
+fprintf (stderr, "anti_dependence %d\n", b);
+ if (b
&& ! sched_insns_conditions_mutex_p (insn, pending->insn ()))
note_mem_dep (t, pending_mem->element (), pending->insn (),
DEP_ANTI);
@@ -2511,7 +2514,10 @@ sched_analyze_1 (class deps_desc *deps,
pending_mem = deps->pending_write_mems;
while (pending)
{
- if (output_dependence (pending_mem->element (), t)
+bool b = output_dependence (pending_mem->element (), t);
+if (sched_deps_info->use_cselib && !DEBUG_INSN_P (insn) && !DEBUG_INSN_P
(pending->insn ()))
+fprintf (stderr, "output_dependence %d\n", b);
+ if (b
&& ! sched_insns_conditions_mutex_p (insn, pending->insn ()))
note_mem_dep (t, pending_mem->element (),
pending->insn (),
@@ -2605,7 +2611,14 @@ sched_analyze_2 (class deps_desc *deps,
case MEM:
{
- if (!DEBUG_INSN_P (insn))
+ if (DEBUG_INSN_P (insn) && sched_deps_info->use_cselib)
+ {
+ machine_mode address_mode = get_address_mode (x);
+
+ cselib_lookup_from_insn (XEXP (x, 0), address_mode, 1,
+ GET_MODE (x), insn);
+ }
+ else if (!DEBUG_INSN_P (insn))
{
/* Reading memory. */
rtx_insn_list *u;
@@ -2630,7 +2643,10 @@ sched_analyze_2 (class deps_desc *deps,
pending_mem = deps->pending_read_mems;
while (pending)
{
- if (read_dependence (pending_mem->element (), t)
+bool b = read_dependence (pending_mem->element (), t);
+if (sched_deps_info->use_cselib && !DEBUG_INSN_P (insn) && !DEBUG_INSN_P
(pending->insn ()))
+fprintf (stderr, "read_dependence %d\n", b);
+ if (b
&& ! sched_insns_conditions_mutex_p (insn,
pending->insn ()))
note_mem_dep (t, pending_mem->element (),
@@ -2645,7 +2661,10 @@ sched_analyze_2 (class deps_desc *deps,
pending_mem = deps->pending_write_mems;
while (pending)
{
- if (true_dependence (pending_mem->element (), VOIDmode, t)
+bool b = true_dependence (pending_mem->element (), VOIDmode, t);
+if (sched_deps_info->use_cselib && !DEBUG_INSN_P (insn) && !DEBUG_INSN_P
(pending->insn ()))
+fprintf (stderr, "true_dependence %d\n", b);
+ if (b
&& ! sched_insns_conditions_mutex_p (insn,
pending->insn ()))
note_mem_dep (t, pending_mem->element (),
@@ -3817,7 +3836,10 @@ sched_analyze (class deps_desc *deps, rt
rtx_insn *insn;
if (sched_deps_info->use_cselib)
+{
cselib_init (CSELIB_RECORD_MEMORY);
+fprintf (stderr, "cselib_init\n");
+}
deps_start_bb (deps, head);
and I see with it a few differences in the output (-g0 to -g):
@@ -603,8 +603,8 @@ read_dependence 0
read_dependence 0
read_dependence 0
read_dependence 0
-true_dependence 0
-true_dependence 0
+true_dependence 1
+true_dependence 1
read_dependence 0
read_dependence 0
read_dependence 0
@@ -616,8 +616,8 @@ read_dependence 0
read_dependence 0
read_dependence 0
read_dependence 0
-true_dependence 0
-true_dependence 0
+true_dependence 1
+true_dependence 1
read_dependence 0
read_dependence 0
read_dependence 0
@@ -630,8 +630,8 @@ read_dependence 0
read_dependence 0
read_dependence 0
read_dependence 0
-true_dependence 0
-true_dependence 0
+true_dependence 1
+true_dependence 1
read_dependence 0
read_dependence 0
read_dependence 0
@@ -645,8 +645,8 @@ read_dependence 0
read_dependence 0
read_dependence 0
read_dependence 0
-true_dependence 0
-true_dependence 0
+true_dependence 1
+true_dependence 1
read_dependence 0
read_dependence 0
read_dependence 0
@@ -735,7 +735,7 @@ read_dependence 0
read_dependence 0
read_dependence 0
read_dependence 0
-true_dependence 0
+true_dependence 1
true_dependence 1
read_dependence 0
read_dependence 0
@@ -757,7 +757,7 @@ read_dependence 0
read_dependence 0
read_dependence 0
true_dependence 1
-true_dependence 0
+true_dependence 1
read_dependence 0
read_dependence 0
read_dependence 0
@@ -801,8 +801,8 @@ read_dependence 0
read_dependence 0
read_dependence 0
read_dependence 0
-true_dependence 0
-true_dependence 0
+true_dependence 1
+true_dependence 1
anti_dependence 1
anti_dependence 0
anti_dependence 1
So, apparently only differences (on this testcase) for true_dependence, will
need to debug in detail what is different in those cases.
next prev parent reply other threads:[~2023-01-26 20:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 11:35 [Bug rtl-optimization/108463] New: " zsojka at seznam dot cz
2023-01-19 11:46 ` [Bug rtl-optimization/108463] " rguenth at gcc dot gnu.org
2023-01-19 11:52 ` jakub at gcc dot gnu.org
2023-01-26 17:28 ` jakub at gcc dot gnu.org
2023-01-26 17:28 ` jakub at gcc dot gnu.org
2023-01-26 18:33 ` jakub at gcc dot gnu.org
2023-01-26 20:00 ` jakub at gcc dot gnu.org [this message]
2023-01-26 20:26 ` jakub at gcc dot gnu.org
2023-01-27 11:26 ` jakub at gcc dot gnu.org
2023-01-27 11:47 ` jakub at gcc dot gnu.org
2023-01-27 11:52 ` jakub at gcc dot gnu.org
2023-01-27 16:47 ` jakub at gcc dot gnu.org
2023-01-27 17:31 ` jakub at gcc dot gnu.org
2023-01-27 18:12 ` jakub at gcc dot gnu.org
2023-01-27 19:07 ` jakub at gcc dot gnu.org
2023-01-30 17:10 ` jakub at gcc dot gnu.org
2023-01-30 17:14 ` jakub at gcc dot gnu.org
2023-02-01 16:39 ` jakub at gcc dot gnu.org
2023-02-02 12:56 ` cvs-commit at gcc dot gnu.org
2023-02-02 12:57 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-108463-4-09gjGXCPP7@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).