From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id EE48B3858D38; Wed, 25 Jan 2023 12:07:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE48B3858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1674648471; bh=6vwduAkzwzvzdMv1swwTbnw+GL7j+N1EbHUlUN4sTK8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=GYbyMkQcLDVQ8J9IfkktigKobKK+JedyAZ5fPIOgRY+kXPK2Lc0yCOIWv4lUzOkV+ CcVUwtaVp7s9sP/Egg3UCX1aInd4PPR2gfVULHSn9I19sg/OOEzmIgMI2ft9i54k3I P9kk8v0bGI4w0m/vZ0Nxro3SS/kFeT5dPtf1WloY= From: "rguenth at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug ipa/108511] [13 regression] ICE in possibly_call_in_translation_unit_p, at cgraph.cc:4184 since r13-5285-g106f99406312d7ed Date: Wed, 25 Jan 2023 12:07:51 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: ipa X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: rguenth at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 13.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108511 Richard Biener changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hubicka at gcc dot gnu.org --- Comment #5 from Richard Biener --- I don't know what the assert really wants to check but /* If callee is local to the original translation unit, it will be defined. */ if (!TREE_PUBLIC (callee->decl) && !DECL_EXTERNAL (callee->decl)) return true; is now possibly "wrong". The cases I changed are DECL_EXTERNAL && !TREE_PU= BLIC to no longer make them TREE_PUBLIC (not sure why the FE sets DECL_EXTERNAL, possibly because it's a declaration). But "local to the original TU" should be just !TREE_PUBLIC, no? Anyway, I can't make real sense of what the function should do, my understanding of the comment doesn't match up with the code ... Honza?=