public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "kargl at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug fortran/108528] [13 Regression] ICE in gfc_compare_array_spec(): Array spec clobbered Date: Tue, 24 Jan 2023 19:08:40 +0000 [thread overview] Message-ID: <bug-108528-4-TSGTGNY1rr@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108528-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108528 kargl at gcc dot gnu.org changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P3 |P4 CC| |kargl at gcc dot gnu.org --- Comment #1 from kargl at gcc dot gnu.org --- The help function causes an ICE when it can simply return false. This then lets gfortran send forth a few error messages. diff --git a/gcc/fortran/array.cc b/gcc/fortran/array.cc index e8a2c32a627..be5eb8b6a0f 100644 --- a/gcc/fortran/array.cc +++ b/gcc/fortran/array.cc @@ -967,7 +967,7 @@ gfc_copy_array_spec (gfc_array_spec *src) /* Returns nonzero if the two expressions are equal. - We should not need to support more than constant values, as thatâs what is + We should not need to support more than constant values, as that's what is allowed in derived type component array spec. However, we may create types with non-constant array spec for dummy variable class container types, for which the _data component holds the array spec of the variable declaration. @@ -979,7 +979,7 @@ compare_bounds (gfc_expr *bound1, gfc_expr *bound2) if (bound1 == NULL || bound2 == NULL || bound1->ts.type != BT_INTEGER || bound2->ts.type != BT_INTEGER) - gfc_internal_error ("gfc_compare_array_spec(): Array spec clobbered"); + return false; /* What qualifies as identical bounds? We could probably just check that the expressions are exact clones. We avoid rewriting a specific comparison
next prev parent reply other threads:[~2023-01-24 19:08 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-24 17:52 [Bug fortran/108528] New: " gscfq@t-online.de 2023-01-24 19:08 ` kargl at gcc dot gnu.org [this message] 2023-01-24 19:08 ` [Bug fortran/108528] " kargl at gcc dot gnu.org 2023-01-24 20:25 ` anlauf at gcc dot gnu.org 2023-01-25 7:36 ` rguenth at gcc dot gnu.org 2023-01-25 19:44 ` anlauf at gcc dot gnu.org 2023-01-25 19:47 ` cvs-commit at gcc dot gnu.org 2023-01-25 19:52 ` sgk at troutmask dot apl.washington.edu 2023-01-25 19:54 ` anlauf at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108528-4-TSGTGNY1rr@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).