From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 3A1C33858D38; Tue, 24 Jan 2023 23:21:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3A1C33858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1674602508; bh=5Ewa0mZLbW5LdnRXXIuLKJn1XrdzIUg1zluMRaziLkw=; h=From:To:Subject:Date:In-Reply-To:References:From; b=UsS8upWPg+avM/4BuJPSfLkOX39dsSGyRXqqKmaiwqakGnTZbiJA/gjDmVGnTr24I znJaNMIFfcfR66mfgwXlN7tB2gbLlU2R0ShXOGQEjxGYM1fLJOS0qrTiQK2+TMwuL3 pxhf76FdRKgRsU/PnSXNqNuUDntsUu+5mn6VQLZ8= From: "redi at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/108530] [13 regression] std/time/tzdb/1.cc fails after r13-5168-g559993b85744ae Date: Tue, 24 Jan 2023 23:21:47 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libstdc++ X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: testsuite-fail X-Bugzilla-Severity: normal X-Bugzilla-Who: redi at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: everconfirmed bug_status cf_reconfirmed_on keywords Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108530 Jonathan Wakely changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |NEW Last reconfirmed| |2023-01-24 Keywords| |testsuite-fail --- Comment #3 from Jonathan Wakely --- (In reply to seurer from comment #2) > Yes it is a regular file. >=20 > With the previous commit it wasn't UNSUPPORTED and worked just fine: Ah, because rather than being UNSUPPORTED, the test was skipping some checks via #if // { dg-additional-options "-DHAVE_TZDB" { target tzdb } } void test_current() { #ifdef HAVE_TZDB const tzdb& db =3D get_tzdb(); const time_zone* tz =3D db.current_zone(); VERIFY( tz =3D=3D std::chrono::current_zone() ); #endif } Previously this machine did not match the effective target tzdb, and so std::chrono::current_zone() was not tested. Now it matches the et, and so t= hat function is tested. And because it's a regular file, that function doesn't work, so we get a FA= IL now. I should really have split that test into two files, one that tests the always-available functionality and one which depends on effective target tz= db. That would have gone from UNSUPPORTED to FAIL for the latter test, instead = of the confusing PASS -> FAIL case we have now for something that never actual= ly worked. PR 108409 tracks some other causes of that function not working, but this o= ne is different. And that reminds me I've seen this before: gcc303 in the comp= ile farm is a FreeBSD 13.0 system, and /etc/localtime is a regular file there t= oo: $ ssh gcc303 file /etc/localtime /etc/localtime: timezone data, version 2, 1 gmt time flag, 1 std time flag,= no leap seconds, no transition times, 1 abbreviation char=