public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/108540] [13 Regression] Frange miscompilation of ruby since r13-3261 Date: Thu, 26 Jan 2023 12:37:42 +0000 [thread overview] Message-ID: <bug-108540-4-1VPvnItzK9@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108540-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108540 --- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> --- --- gcc/range-op-float.cc.jj 2023-01-16 09:39:36.191929750 +0100 +++ gcc/range-op-float.cc 2023-01-26 13:33:48.712018907 +0100 @@ -607,6 +607,10 @@ foperator_equal::fold_range (irange &r, { if (op1 == op2) r = range_true (type); + // If one operand is -0.0 and other 0.0, they are still equal. + else if (real_iszero (&op1.lower_bound ()) + && real_iszero (&op2.lower_bound ())) + r = range_true (type); else r = range_false (type); } @@ -617,7 +621,18 @@ foperator_equal::fold_range (irange &r, frange tmp = op1; tmp.intersect (op2); if (tmp.undefined_p ()) - r = range_false (type); + { + // If one range is [whatever, -0.0] and another + // [0.0, whatever2], we don't know anything either, + // because -0.0 == 0.0. + if ((real_iszero (&op1.upper_bound ()) + && real_iszero (&op2.lower_bound ())) + || (real_iszero (&op1.lower_bound ()) + && real_iszero (&op2.upper_bound ()))) + r = range_true_and_false (type); + else + r = range_false (type); + } else r = range_true_and_false (type); } fixes both testcases, but I'm afraid I need to look at other relations too with -0.0 == 0.0 in mind.
next prev parent reply other threads:[~2023-01-26 12:37 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-25 15:48 [Bug tree-optimization/108540] New: " jakub at gcc dot gnu.org 2023-01-25 15:52 ` [Bug tree-optimization/108540] " jakub at gcc dot gnu.org 2023-01-26 11:27 ` jakub at gcc dot gnu.org 2023-01-26 11:41 ` jakub at gcc dot gnu.org 2023-01-26 12:16 ` jakub at gcc dot gnu.org 2023-01-26 12:37 ` jakub at gcc dot gnu.org [this message] 2023-01-26 13:08 ` jakub at gcc dot gnu.org 2023-01-26 13:29 ` aldyh at gcc dot gnu.org 2023-01-26 16:28 ` cvs-commit at gcc dot gnu.org 2023-01-27 20:39 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108540-4-1VPvnItzK9@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).