From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id B93B63858C53; Wed,  1 Mar 2023 14:24:59 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B93B63858C53
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1677680699;
	bh=O8ORMWniyscWmbcjSR9j9fyyGzs/YVJ65euQm3/v3LA=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=r8roL4w32+voj5b2rS8J/kFRMg0AiHDD7YibuvyKiIWDbVLSciRTZm1li+nDdDgNd
	 bBMbMaGibmreCXThPCE5YaqcDzqxAxy+FSRYQNuOZSczprQkQPT3CV4/Hkrb8sxH69
	 1r41pK2TznSU7Rhl/0q9mmkFMGM9hZ5qp1T64z8I=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/108545] [13 Regression] ICE in install_var_field, at
 omp-low.cc:799 since r13-2665-g23baa717c991d77f
Date: Wed, 01 Mar 2023 14:24:58 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: middle-end
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code, openmp
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: burnus at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108545-4-o8FwJgEd0f@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108545-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108545-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108545

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tobias Burnus <burnus@gcc.gnu.org>:

https://gcc.gnu.org/g:3843dc1460259fbca1f336b0259f0b6b527d77ae

commit r13-6394-g3843dc1460259fbca1f336b0259f0b6b527d77ae
Author: Tobias Burnus <tobias@codesourcery.com>
Date:   Wed Mar 1 15:11:53 2023 +0100

    OpenMP: Ignore side-effects when finding struct comps [PR108545]

    With volatile, two 'x.data' comp refs aren't regarded as identical,
    causing that the two items in the first map of
      map(to:x.a, x.a.data) map(pset: x.a.data)
    end up in separate 'map(struct:x)', which will cause a later ICE.

    Solution: Ignore side effects when checking the operands in the hash
    for being equal. (Do so by creating a variant of tree_operand_hash
    that calls operand_equal_p with OEP_MATCH_SIDE_EFFECTS.)

    gcc/ChangeLog:

            PR middle-end/108545
            * gimplify.cc (struct tree_operand_hash_no_se): New.
            (omp_index_mapping_groups_1, omp_index_mapping_groups,
            omp_reindex_mapping_groups, omp_mapped_by_containing_struct,
            omp_tsort_mapping_groups_1, omp_tsort_mapping_groups,
            oacc_resolve_clause_dependencies, omp_build_struct_sibling_list=
s,
            gimplify_scan_omp_clauses): Use tree_operand_hash_no_se instead
            of tree_operand_hash.

    gcc/testsuite/ChangeLog:

            PR middle-end/108545
            * c-c++-common/gomp/map-8.c: New test.
            * gfortran.dg/gomp/map-9.f90: New test.=