public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug modula2/108555] gm2_langhook_option_lang_mask causes all (unappropriate) C language options to be recognized
Date: Thu, 26 Jan 2023 12:26:23 +0000	[thread overview]
Message-ID: <bug-108555-4-Ag0wxU6Ofe@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108555-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108555

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Iain Sandoe from comment #2)
> We do claim the ones that modula-2 actually uses in gm2-lang.opt
> 
> (previous to r13-5373-g80cf2c5e8f496b we had a large and growing set to
> accommodate everything that the preprocessor needs).
> 
> Because of that growing number of added options, this change was made
> intentionally... the idea was to claim and act on the C and Driver ones that
> are used to construct C-preprocessor command lines as an action separate
> from handling the Modula-2 options.
> 
> IIUC, the mechanism of adding them to the language opt is a convention
> rather than a correctness issue?

Kind-of ...

> Or is it that we should reject rather than ignoring the options that we do
> not pass to the preprocessor?

... yes, you are short-cutting generic code that diagnoses and removes
unappropriate options, I'm not sure simulating that behavior is easily
possible.

> (I can revert to adding everything to the gm2-lang.opt .. it just seemed a
> bit hacky)

  parent reply	other threads:[~2023-01-26 12:26 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26  9:46 [Bug modula2/108555] New: " rguenth at gcc dot gnu.org
2023-01-26  9:51 ` [Bug modula2/108555] " rguenth at gcc dot gnu.org
2023-01-26 10:19 ` iains at gcc dot gnu.org
2023-01-26 12:26 ` rguenth at gcc dot gnu.org [this message]
2023-01-26 13:10 ` iains at gcc dot gnu.org
2023-01-26 16:38 ` iains at gcc dot gnu.org
2023-01-26 20:30 ` iains at gcc dot gnu.org
2023-01-27  8:48 ` cvs-commit at gcc dot gnu.org
2023-01-27 10:07 ` rguenth at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108555-4-Ag0wxU6Ofe@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).