public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/108573] [13 Regression] '-fcompare-debug' failure (length) at -O2
Date: Tue, 31 Jan 2023 17:46:23 +0000	[thread overview]
Message-ID: <bug-108573-4-bJYJ5yoNPR@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108573-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108573

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
--- gcc/ree.cc.jj       2023-01-02 09:32:45.327953792 +0100
+++ gcc/ree.cc  2023-01-31 18:36:31.253018233 +0100
@@ -875,7 +875,8 @@ combine_reaching_defs (ext_cand *cand, c

          for (df_link *use = uses; use; use = use->next)
            if (paradoxical_subreg_p (GET_MODE (*DF_REF_LOC (use->ref)),
-                                     GET_MODE (SET_DEST (*dest_sub_rtx))))
+                                     GET_MODE (SET_DEST (*dest_sub_rtx))) 
+               && !DEBUG_INSN_P (DF_REF_INSN (use->ref)))
              return false;
        }

fixes this particular -fcompare-debug failure.  Dunno though about get_uses, it
performs some checks and returns NULL if those fail (again, ignoring if the
failures are from DEBUG_INSNs or something else), plus in theory there could be
a non-NULL ref_chain of only debug uses (though hopefully we prevent that).
And there is another spot that would need the same change as above.

  parent reply	other threads:[~2023-01-31 17:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 16:38 [Bug debug/108573] New: " zsojka at seznam dot cz
2023-01-30  7:58 ` [Bug debug/108573] " rguenth at gcc dot gnu.org
2023-01-31 16:38 ` jakub at gcc dot gnu.org
2023-01-31 17:05 ` jakub at gcc dot gnu.org
2023-01-31 17:46 ` jakub at gcc dot gnu.org [this message]
2023-02-01 11:53 ` cvs-commit at gcc dot gnu.org
2023-02-01 11:54 ` jakub at gcc dot gnu.org
2023-02-10 17:46 ` cvs-commit at gcc dot gnu.org
2023-05-02 20:14 ` cvs-commit at gcc dot gnu.org
2023-05-03 15:21 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108573-4-bJYJ5yoNPR@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).