public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c++/108579] [13 Regression] Requires-expression that checks constructor on non-template constructor of template class got rejected Date: Fri, 03 Feb 2023 14:15:42 +0000 [thread overview] Message-ID: <bug-108579-4-8zhKkFshqJ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108579-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108579 --- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Patrick Palka <ppalka@gcc.gnu.org>: https://gcc.gnu.org/g:e7930c6750d03b28d922ebbbace20ba9d8622c6a commit r13-5682-ge7930c6750d03b28d922ebbbace20ba9d8622c6a Author: Patrick Palka <ppalka@redhat.com> Date: Fri Feb 3 09:12:31 2023 -0500 c++: excessive satisfaction in check_methods [PR108579] In check_methods we're unnecessarily checking satisfaction for all constructors and assignment operators, even those that don't look like copy/move special members. In the testcase below this manifests as an unstable satisfaction error because the satisfaction result is first determined to be false during check_methods (since A<int> is incomplete at this point) and later true after completion of A<int>. This patch fixes this simply by swapping the order of the constraint_satisfied_p and copy/move_fn_p tests. PR c++/108579 gcc/cp/ChangeLog: * class.cc (check_methods): Swap order of constraints_satisfied_p and copy/move_fn_p tests. gcc/testsuite/ChangeLog: * g++.dg/cpp2a/concepts-pr108579.C: New test.
next prev parent reply other threads:[~2023-02-03 14:15 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-28 7:40 [Bug c++/108579] New: " gnaggnoyil at gmail dot com 2023-01-28 8:00 ` [Bug c++/108579] [13 Regression] " pinskia at gcc dot gnu.org 2023-01-29 10:56 ` redi at gcc dot gnu.org 2023-01-30 18:31 ` ppalka at gcc dot gnu.org 2023-02-03 14:15 ` cvs-commit at gcc dot gnu.org [this message] 2023-02-03 14:16 ` ppalka at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108579-4-8zhKkFshqJ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).