public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "tnfchris at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/108583] [13 Regression] wrong code with vector division by uint16 at -O2 Date: Mon, 30 Jan 2023 14:20:50 +0000 [thread overview] Message-ID: <bug-108583-4-2LbLqidvVL@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108583-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108583 Tamar Christina <tnfchris at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rguenth at gcc dot gnu.org, | |rsandifo at gcc dot gnu.org --- Comment #3 from Tamar Christina <tnfchris at gcc dot gnu.org> --- Right, so this is because in the expansion we don't have enough context to decide how to optimize the division. This optimization is only possible when the input is widened because you need an additional free bit so that the second addition can't overflow. The vectorizer has this context but since we didn't want a new IFN the context should instead be derivable in targetm.vectorize.can_special_div_by_const hook. So my proposal to fix this and keep targetm.vectorize.can_special_div_by_const as a general divide optimization hook is to pass the actual `tree` operand0 as well to the hook such that the hook has a bit more context. I was hoping to use get_nonzero_bits to get what the actual range of the operand is. But it looks like for widening operations it still reports -1. So my suggestion is the backend should just check if the operand is a non-constant and the type of the operation being performed is matches the precision we require. Is this ok with you Richards? since I'll need both of you to approve.
next prev parent reply other threads:[~2023-01-30 14:20 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-28 14:00 [Bug rtl-optimization/108583] New: " zsojka at seznam dot cz 2023-01-30 4:19 ` [Bug target/108583] " pinskia at gcc dot gnu.org 2023-01-30 4:22 ` pinskia at gcc dot gnu.org 2023-01-30 8:31 ` rguenth at gcc dot gnu.org 2023-01-30 14:20 ` tnfchris at gcc dot gnu.org [this message] 2023-01-30 14:52 ` rguenther at suse dot de 2023-01-30 15:01 ` tnfchris at gcc dot gnu.org 2023-01-30 16:52 ` rsandifo at gcc dot gnu.org 2023-01-30 17:04 ` tnfchris at gcc dot gnu.org 2023-01-31 10:31 ` rguenth at gcc dot gnu.org 2023-01-31 11:01 ` rsandifo at gcc dot gnu.org 2023-01-31 11:39 ` tnfchris at gcc dot gnu.org 2023-01-31 11:44 ` rguenther at suse dot de 2023-01-31 11:58 ` tnfchris at gcc dot gnu.org 2023-01-31 12:03 ` rsandifo at gcc dot gnu.org 2023-01-31 12:19 ` rguenther at suse dot de 2023-01-31 13:35 ` tnfchris at gcc dot gnu.org 2023-01-31 14:33 ` rguenther at suse dot de 2023-01-31 14:45 ` rguenther at suse dot de 2023-01-31 15:01 ` tnfchris at gcc dot gnu.org 2023-02-01 7:29 ` rguenther at suse dot de 2023-02-01 16:22 ` tnfchris at gcc dot gnu.org 2023-02-02 8:03 ` tnfchris at gcc dot gnu.org 2023-02-02 8:50 ` rguenther at suse dot de 2023-02-02 8:55 ` tnfchris at gcc dot gnu.org 2023-02-08 13:57 ` tnfchris at gcc dot gnu.org 2023-02-09 7:41 ` rguenther at suse dot de 2023-03-12 18:43 ` cvs-commit at gcc dot gnu.org 2023-03-12 18:43 ` cvs-commit at gcc dot gnu.org 2023-03-12 18:43 ` cvs-commit at gcc dot gnu.org 2023-03-12 18:44 ` cvs-commit at gcc dot gnu.org 2023-03-12 18:44 ` cvs-commit at gcc dot gnu.org 2023-03-12 18:45 ` tnfchris at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108583-4-2LbLqidvVL@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).