From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 84388385800A; Thu,  2 Feb 2023 09:03:01 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 84388385800A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1675328581;
	bh=1f3OGEUhjN9meTXvHxMKra2XLrq55uwDNTqEbXoWvQ8=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=o1WueeA9zn9QoGDf4WT4NPJJONikYjvftOPQycQW4kYFO1F5cxnhh832qxacBd/L3
	 VX6GnKGxSJemM2pBzEcsEp+dQmBReBpHJadY1K6aeoOC26c7XHUDNA+4qpxmU3bCvL
	 5WtCUp0zIlQpLMB9jtxor/ED1a5avBbV0Uwe8g1Y=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/108601] [13 Regression] vector peeling ICEs
 with VLA in gcc_r in SPEC2017 since
 g:c13223b790bbc5e4a3f5605e057eac59b61b2c85
Date: Thu, 02 Feb 2023 09:02:59 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108601-4-NCEMDlkb7n@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108601-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108601-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108601

--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by hongtao Liu <liuhongt@gcc.gnu.org>:

https://gcc.gnu.org/g:209f02b0a9e9adc0bf0247cb5eef04e0f175d64e

commit r13-5644-g209f02b0a9e9adc0bf0247cb5eef04e0f175d64e
Author: liuhongt <hongtao.liu@intel.com>
Date:   Wed Feb 1 13:30:12 2023 +0800

    Don't peel nonlinear iv(mult or shift) for epilog when vf is not consta=
nt.

    Normally when vf is not constant, it will be prevented by
    vectorizable_nonlinear_inductions, but for this case, it failed going
    into

        if (STMT_VINFO_RELEVANT_P (stmt_info))
          {
            need_to_vectorize =3D true;
            if (STMT_VINFO_DEF_TYPE (stmt_info) =3D=3D vect_induction_def
               && ! PURE_SLP_STMT (stmt_info))
              ok =3D vectorizable_induction (loop_vinfo,
                                           stmt_info, NULL, NULL,
                                           &cost_vec);

    since the iv is never used outside of the loop, and will be dce later, =
so
    vectorizer doesn't bother checking if it's vectorizable. it's
    true but hit gcc_assert in vect_can_peel_nonlinear_iv_p when vf is not
    constant. One solution is ignoring the nonlinear iv peeling if it's
    !STMT_VINFO_RELEVANT_P (stmt_info) just like the upper code, the other
    solution is returning false earlier in the
    vect_can_peel_nonlinear_iv_p when vf is not constant, the patch chooses
    the second incase there's other cases using vect_can_advance_ivs_p which
    calls vect_can_peel_nonlinear_iv_p.
    Also remove vect_peel_nonlinear_iv_p from
    vectorizable_nonlinear_inductions.

    gcc/ChangeLog:

            PR tree-optimization/108601
            * tree-vectorizer.h (vect_can_peel_nonlinear_iv_p): Removed.
            * tree-vect-loop.cc
            (vectorizable_nonlinear_induction): Remove
            vect_can_peel_nonlinear_iv_p.
            (vect_can_peel_nonlinear_iv_p): Don't peel
            nonlinear iv(mult or shift) for epilog when vf is not
            constant and moved the defination to ..
            * tree-vect-loop-manip.cc (vect_can_peel_nonlinear_iv_p):
            .. Here.

    gcc/testsuite/ChangeLog:

            * gcc.target/aarch64/pr108601.c: New test.=