From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id BCEA63858CDB; Mon, 6 Feb 2023 10:37:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BCEA63858CDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1675679836; bh=J52TQn9yRizBaersuPDuG/7eDoxDnSNeO7tuCZl5shM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=OJOeJ4SGRkHRfxbYNjqeXdYYS+HKn1cY6AB0X3FLH/j58M+ZmVu/BT7xqJhhYr0pU Ms7px4MiaB6o+3nGJy061pevF9ki71k/X4l1jx3AUJQ/p8JvA87lZqekj2TS6b+S+G F02XhaAwd+bYtsa9+1LiacEm9HtFNjmKtTicCrXw= From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug debug/108656] [12/13 Regression] '-fcompare-debug' failure (length) w/ -O2 -fno-ipa-pure-const -fno-tree-dce --param early-inlining-insns=0 since r12-5236 Date: Mon, 06 Feb 2023 10:37:16 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: debug X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: compare-debug-failure X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 12.3 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108656 --- Comment #12 from Jakub Jelinek --- (In reply to rguenther@suse.de from comment #11) > On Mon, 6 Feb 2023, jakub at gcc dot gnu.org wrote: >=20 > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108656 > >=20 > > --- Comment #10 from Jakub Jelinek --- > > Anyway, if we decided that it is ok to have just the incoming ab edges,= we'd > > need to change any code that can DCE or inline calls to update abnormal= edges > > not just for the case where the last stmt used to be can_make_abnormal_= goto and > > no longer is, but also for the case when the first stmt was returns_twi= ce call > > and no longer is, in that case we'd need to drop that abnormal edge poi= nting to > > the start of the bb from the .ABNORMAL_DISPATCHER block. >=20 > Doesn't cleanup CFG do this via removal of the unreachable=20 > .ABNORMAL_DISPATCHER? If all non-pure calls are removed (all can_make_abnormal_goto to be precise= ), sure. Or if we reset and recompute cfun->calls_setjmp and then do cfg clea= nup. The problem on the above testcase is that it can never happen or takes many passes. The returns_twice function is gone during einline pass, but there are other calls that can make abnormal goto (well, have side-effects and nothing noti= ced we don't have any returns_twice calls anymore). So we have an ab edge poin= ting to a bb that doesn't start with returns_twice function, that alone looks wr= ong to me. During IPA we then inline further functions and diverge on when we trigger the removal on outgoing abnormal edges because of debug stmts.=