public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/108684] [12/13 Regression] ICE: verify_ssa failed
Date: Fri, 10 Feb 2023 01:47:48 +0000	[thread overview]
Message-ID: <bug-108684-4-336pW3mfaa@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108684-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108684

--- Comment #13 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:6a5cb782d1486b378d70857c8efae558da0eb2cc

commit r13-5768-g6a5cb782d1486b378d70857c8efae558da0eb2cc
Author: Andrew Pinski <apinski@marvell.com>
Date:   Tue Feb 7 23:09:40 2023 +0000

    tree-optimization: [PR108684] ICE in verify_ssa due to
simple_dce_from_worklist

    In simple_dce_from_worklist, we were removing an inline-asm which had a
vdef.
    We should not be removing inline-asm which have a vdef as this code
    does not check to the store.
    This fixes that oversight. This was a latent bug exposed recently
    by both VRP and removal of stores to static starting to use
    simple_dce_from_worklist.

    Committed as approved.
    Bootstrapped and tested on x86_64-linux-gnu with no regressions.

            PR tree-optimization/108684

    gcc/ChangeLog:

            * tree-ssa-dce.cc (simple_dce_from_worklist):
            Check all ssa names and not just non-vdef ones
            before accepting the inline-asm.
            Call unlink_stmt_vdef on the statement before
            removing it.

    gcc/testsuite/ChangeLog:

            * gcc.c-torture/compile/dce-inline-asm-1.c: New test.
            * gcc.c-torture/compile/dce-inline-asm-2.c: New test.
            * gcc.dg/tree-ssa/pr108684-1.c: New test.

    co-authored-by: Andrew Macleod  <amacleod@redhat.com>

  parent reply	other threads:[~2023-02-10  1:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-06 18:49 [Bug c++/108684] New: [13 " gscfq@t-online.de
2023-02-06 18:55 ` [Bug tree-optimization/108684] " pinskia at gcc dot gnu.org
2023-02-06 20:23 ` pinskia at gcc dot gnu.org
2023-02-06 20:26 ` pinskia at gcc dot gnu.org
2023-02-07 14:05 ` rguenth at gcc dot gnu.org
2023-02-07 18:30 ` amacleod at redhat dot com
2023-02-07 18:33 ` pinskia at gcc dot gnu.org
2023-02-07 18:37 ` [Bug tree-optimization/108684] [12/13 " pinskia at gcc dot gnu.org
2023-02-07 18:39 ` amacleod at redhat dot com
2023-02-07 18:45 ` pinskia at gcc dot gnu.org
2023-02-07 19:56 ` pinskia at gcc dot gnu.org
2023-02-07 19:59 ` jakub at gcc dot gnu.org
2023-02-07 20:03 ` pinskia at gcc dot gnu.org
2023-02-08 19:14 ` pinskia at gcc dot gnu.org
2023-02-09 15:23 ` pinskia at gcc dot gnu.org
2023-02-10  1:47 ` cvs-commit at gcc dot gnu.org [this message]
2023-02-10  1:48 ` [Bug tree-optimization/108684] [12 " pinskia at gcc dot gnu.org
2023-03-10 21:55 ` cvs-commit at gcc dot gnu.org
2023-03-10 21:55 ` pinskia at gcc dot gnu.org
2023-05-13 14:17 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108684-4-336pW3mfaa@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).