From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 62C5F3857BB3; Fri, 10 Mar 2023 21:55:18 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62C5F3857BB3
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1678485318;
	bh=qV6h1iBWSDib8aJJuCW5r8vtuLd/hXTqBieejezbLe0=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=FvAcN+Tr4xp1E5pd1ZHh5ZTtxtPW91oEHkEMlL0nrAQQoGuhLEKtLxtGRBMpY64e/
	 LP12PFjuuSArIfNU+yj3ogVDIvp6H7ds1hGFgsUbsxDwbYi+QgIaOFEOf+5W2TFJhk
	 OC27A/juzJSmFf+DAWw5GywbzYvnzSMIZqdG3oXg=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/108684] [12 Regression] ICE: verify_ssa
 failed
Date: Fri, 10 Mar 2023 21:55:17 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code, inline-asm, patch, wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: pinskia at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108684-4-KB8KugLGRK@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108684-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108684-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108684

--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Andrew Pinski
<pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:657e1e89d34b114ca47fe1f2c5366927c5850af7

commit r12-9239-g657e1e89d34b114ca47fe1f2c5366927c5850af7
Author: Andrew Pinski <apinski@marvell.com>
Date:   Tue Feb 7 23:09:40 2023 +0000

    tree-optimization: [PR108684] ICE in verify_ssa due to
simple_dce_from_worklist

    In simple_dce_from_worklist, we were removing an inline-asm which had a
vdef.
    We should not be removing inline-asm which have a vdef as this code
    does not check to the store.
    This fixes that oversight. This was a latent bug exposed recently
    by both VRP and removal of stores to static starting to use
    simple_dce_from_worklist.

    Backported after bootstrapped and tested on x86_64-linux-gnu with no
regressions.

            PR tree-optimization/108684

    gcc/ChangeLog:

            * tree-ssa-dce.cc (simple_dce_from_worklist):
            Check all ssa names and not just non-vdef ones
            before accepting the inline-asm.
            Call unlink_stmt_vdef on the statement before
            removing it.

    gcc/testsuite/ChangeLog:

            * gcc.c-torture/compile/dce-inline-asm-1.c: New test.
            * gcc.c-torture/compile/dce-inline-asm-2.c: New test.
            * gcc.dg/tree-ssa/pr108684-1.c: New test.

    co-authored-by: Andrew Macleod  <amacleod@redhat.com>
    (cherry picked from commit 6a5cb782d1486b378d70857c8efae558da0eb2cc)=