public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/108696] querying relations is slow
Date: Fri, 10 Feb 2023 08:38:03 +0000 [thread overview]
Message-ID: <bug-108696-4-7rrIVCXfVW@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108696-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108696
--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Andrew Macleod from comment #2)
> Created attachment 54437 [details]
> possible patch
>
> This patch should successfully short circuit unnecessary checks. untested in
> compiler.i
>
> Where did you get a 17% time in DOM? when I run compiler.i I get
> dominator optimization : 38.28 ( 2%)
> where most of the time is in
> machine dep reorg :1447.64 ( 60%)
>
> I'll check this patch for correctness and to see if it generally makes any
> time improvements that are measurable elsewhere.
It helps the callgrind profile but doesn't show any effect on the -ftime-report
or a perf profile. For the testcase the bitmap operations in ranger are
definitely visible in a perf profile (with call traces), and with -O1 it's
mostly DOM and jump-threading that perform any ranger ops when diagnostics are
disabled.
That said, not allocating the self-relation bitmaps at query time is
definitely good (not 100% sure if the patch achieves that).
next prev parent reply other threads:[~2023-02-10 8:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 13:00 [Bug tree-optimization/108696] New: " rguenth at gcc dot gnu.org
2023-02-08 17:16 ` [Bug tree-optimization/108696] " amacleod at redhat dot com
2023-02-08 17:50 ` amacleod at redhat dot com
2023-02-08 18:01 ` rguenther at suse dot de
2023-02-10 8:38 ` rguenth at gcc dot gnu.org [this message]
2023-02-10 14:53 ` amacleod at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-108696-4-7rrIVCXfVW@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).