public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug debug/108716] [10/11 Regression] Incorrect DW_AT_decl_{line,column} in DW_TAG_imported_decl
Date: Tue, 02 May 2023 20:15:17 +0000	[thread overview]
Message-ID: <bug-108716-4-VyRuVY9yxE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108716-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108716

--- Comment #6 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:2a6b112404837a3119985b58b886f63a88ec2cab

commit r11-10718-g2a6b112404837a3119985b58b886f63a88ec2cab
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Thu Mar 2 19:17:52 2023 +0100

    c++, debug: Fix up locus of DW_TAG_imported_module [PR108716]

    Before IMPORTED_DECL has been introduced in PR37410, we used to emit
correct
    DW_AT_decl_line on DW_TAG_imported_module on the testcase below, after that
    change we haven't emitted it at all for a while and after some time
    started emitting incorrect locus, in particular the location of } closing
    the function.

    The problem is that while we have correct EXPR_LOCATION on the USING_STMT,
    when genericizing that USING_STMT into IMPORTED_DECL we don't copy the
    location to DECL_SOURCE_LOCATION, so it gets whatever input_location
happens
    to be when it is created.

    2023-03-02  Jakub Jelinek  <jakub@redhat.com>

            PR debug/108716
            * cp-gimplify.c (cp_genericize_r) <case USING_STMT>: Set
            DECL_SOURCE_LOCATION on IMPORTED_DECL to expression location
            of USING_STMT or input_location.

            * g++.dg/debug/dwarf2/pr108716.C: New test.

    (cherry picked from commit 4d82022bfd15d36717bf60a11e75e9ea02204269)

  parent reply	other threads:[~2023-05-02 20:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 10:47 [Bug debug/108716] New: [10/11/12/13 " jakub at gcc dot gnu.org
2023-02-08 10:47 ` [Bug debug/108716] " jakub at gcc dot gnu.org
2023-02-08 10:53 ` jakub at gcc dot gnu.org
2023-03-02 18:19 ` cvs-commit at gcc dot gnu.org
2023-03-02 18:21 ` [Bug debug/108716] [10/11/12 " jakub at gcc dot gnu.org
2023-03-19  5:30 ` cvs-commit at gcc dot gnu.org
2023-03-20 10:28 ` [Bug debug/108716] [10/11 " jakub at gcc dot gnu.org
2023-05-02 20:15 ` cvs-commit at gcc dot gnu.org [this message]
2023-05-03 10:38 ` [Bug debug/108716] [10 " jakub at gcc dot gnu.org
2023-05-03 15:22 ` cvs-commit at gcc dot gnu.org
2023-05-04  7:25 ` jakub at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108716-4-VyRuVY9yxE@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).