public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "aaron at aaronballman dot com" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/108796] Can't intermix C2x and GNU style attributes Date: Thu, 16 Feb 2023 22:34:37 +0000 [thread overview] Message-ID: <bug-108796-4-rLBAVtScku@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108796-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108796 --- Comment #10 from Aaron Ballman <aaron at aaronballman dot com> --- One other reason for the Clang behavior that may be worth mentioning is that this helps users who wish to migrate away from `__attribute__` and towards `[[]]`. Many (most?) uses of attributes end up behind a macro, so the user may not even be aware which syntax is being used. Consider this contrived example: ``` // LibraryHeader.h #if SOMETHING #define FOO_ATTR __attribute__((foo)) #define BAR_ATTR __attribute__((bar)) #define BAZ_ATTR [[lib::baz]] #elif SOMETHING_ELSE ... #else #define FOO_ATTR #define BAR_ATTR #define BAZ_ATTR #endif // UserCode.c FOO_ATTR BAR_ATTR void func(void) { ... } ``` The user reading UserCode.c has no idea what attribute syntax is being used, nor do they probably care all that much. Under a strict parsing model, trying to add `BAZ_ATTR` to the declaration of `func()` requires the user to be very aware of exactly what each macro expands to, otherwise they might get the order wrong. With a relaxed parsing model, the user doesn't have to care. Additionally, the library header can migrate `BAR_ATTR` to `[[gnu::bar]]` syntax without also migrating `FOO_ATTR` at the same time with less fear of breaking downstream users due to attribute ordering, so this allows for gradual migration to a newer syntax. (It's not "no fear" because `[[]]` has strict appertainment rules, so it's possible for some attributes to break user code when migrating from `__attribute__` to `[[]]` due to differences in appertainment.)
next prev parent reply other threads:[~2023-02-16 22:34 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-15 3:07 [Bug c/108796] New: GCC 13 accepts [[noreturn]] attribute without -std=c2x sam at gentoo dot org 2023-02-15 3:10 ` [Bug c/108796] " sam at gentoo dot org 2023-02-15 3:11 ` sam at gentoo dot org 2023-02-15 3:44 ` sam at gentoo dot org 2023-02-15 3:46 ` pinskia at gcc dot gnu.org 2023-02-15 3:47 ` [Bug c/108796] Can't intermix C2x and GNU style attributes pinskia at gcc dot gnu.org 2023-02-15 21:02 ` joseph at codesourcery dot com 2023-02-16 13:14 ` aaron at aaronballman dot com 2023-02-16 19:20 ` joseph at codesourcery dot com 2023-02-16 20:06 ` aaron at aaronballman dot com 2023-02-16 22:34 ` aaron at aaronballman dot com [this message] 2024-01-14 10:26 ` pinskia at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108796-4-rLBAVtScku@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).