public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/108819] [12/13 Regression] ICE on valid code at -O1 with "-fno-tree-ccp -fno-tree-forwprop" on x86_64-linux-gnu: tree check: expected ssa_name, have integer_cst in number_of_iterations_cltz, at tree-ssa-loop-niter.cc:2394 Date: Fri, 17 Feb 2023 13:20:23 +0000 [thread overview] Message-ID: <bug-108819-4-Z6XyIKc4xU@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108819-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108819 Richard Biener <rguenth at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> --- I have a patch to make niter analysis more defensive, the 1 & 1 is introduced by reassoc: @@ -30,8 +54,8 @@ <bb 4> [local count: 114863530]: _20 = a.0_1 == 0; _21 = a.0_1 > 0; - _22 = _20 & _21; - if (_22 != 0) + _7 = 1 & 1; + if (_7 != 0) where update_range_test gets a '1' as result and forces that to an SSA name and things go downhill from that. With diff --git a/gcc/tree-ssa-reassoc.cc b/gcc/tree-ssa-reassoc.cc index f163612f140..c2b30a03a9d 100644 --- a/gcc/tree-ssa-reassoc.cc +++ b/gcc/tree-ssa-reassoc.cc @@ -2950,6 +2950,9 @@ update_range_test (struct range_entry *range, struct range_entry *otherrange, } if (stmt == NULL) gcc_checking_assert (tem == op); + /* When range->exp is a constant, we can use it as-is. */ + else if (is_gimple_min_invariant (tem)) + ; /* In rare cases range->exp can be equal to lhs of stmt. In that case we have to insert after the stmt rather then before it. If stmt is a PHI, insert it at the start of the basic block. */ this is resolved (but we still get the intermediate 1 & 1 created). Jakub, you know this code more(?), can you see whether there's a better place to handle this? I'm testing the niter fortification.
next prev parent reply other threads:[~2023-02-17 13:20 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-16 10:35 [Bug tree-optimization/108819] New: " zhendong.su at inf dot ethz.ch 2023-02-16 15:39 ` [Bug tree-optimization/108819] [13 Regression] " pinskia at gcc dot gnu.org 2023-02-16 19:34 ` [Bug tree-optimization/108819] [12/13 " pinskia at gcc dot gnu.org 2023-02-17 7:59 ` rguenth at gcc dot gnu.org 2023-02-17 13:20 ` rguenth at gcc dot gnu.org [this message] 2023-02-17 16:46 ` jakub at gcc dot gnu.org 2023-02-18 11:41 ` cvs-commit at gcc dot gnu.org 2023-02-18 11:42 ` [Bug tree-optimization/108819] [12 " jakub at gcc dot gnu.org 2023-02-20 7:44 ` cvs-commit at gcc dot gnu.org 2023-03-19 5:29 ` cvs-commit at gcc dot gnu.org 2023-03-20 10:26 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108819-4-Z6XyIKc4xU@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).