public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug c/108880] [11/12/13 Regression] slow compilation with "-fsanitize=undefined" Date: Wed, 22 Feb 2023 19:48:29 +0000 [thread overview] Message-ID: <bug-108880-4-UAOALlVRI4@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-108880-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108880 --- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> --- (In reply to Richard Biener from comment #4) > It's not only "slow", it also produces a gigantic executable, the .original > dump was 7.1GB when I stopped the compilation ... Well, original dump for deeply nested SAVE_EXPRs is pretty unusable, even when the actual trees are fairly small, because it prints each SAVE_EXPR in full. If we wanted to avoid that, we'd need to use during the printing some hash table on which SAVE_EXPRs we have printed already and print some id for them and print just that id rather than full content next time we see it. Or perhaps trigger that behavior when we see deeper SAVE_EXPR nesting. > The culprit is c_genericize calling c_genericize_control_r which must > somehow do the ubsan instrumentation as well. As Marek said, on the C++ FE side this is handled by cp-gimplify.cc using a pset on its own and not trying to genericize a control stmt which has been handled already (e.g. when seeing it again in another SAVE_EXPR), or even SAVE_EXPRs that have been handled already. So, adding another pset that would be used also for C++ would be a waste. Now, the C FE in c-gimplify.cc has: walk_tree_without_duplicates (&DECL_SAVED_TREE (fndecl), c_genericize_control_r, NULL); so it effectively already creates a pset. Thus, I think we should replace this walk_tree_without_duplicates with a new pset + walk_tree, pass &pset twice - as pset and data and in c_genericize_control_r don't walk again what we've already walked. which
next prev parent reply other threads:[~2023-02-22 19:48 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-22 6:41 [Bug sanitizer/108880] New: " qrzhang at gatech dot edu 2023-02-22 6:51 ` [Bug sanitizer/108880] [11/12/13 Regression] " pinskia at gcc dot gnu.org 2023-02-22 6:53 ` pinskia at gcc dot gnu.org 2023-02-22 6:54 ` pinskia at gcc dot gnu.org 2023-02-22 7:12 ` pinskia at gcc dot gnu.org 2023-02-22 10:25 ` [Bug c/108880] " rguenth at gcc dot gnu.org 2023-02-22 10:25 ` rguenth at gcc dot gnu.org 2023-02-22 15:41 ` mpolacek at gcc dot gnu.org 2023-02-22 15:51 ` mpolacek at gcc dot gnu.org 2023-02-22 16:16 ` mpolacek at gcc dot gnu.org 2023-02-22 18:24 ` mpolacek at gcc dot gnu.org 2023-02-22 19:46 ` mpolacek at gcc dot gnu.org 2023-02-22 19:48 ` jakub at gcc dot gnu.org [this message] 2023-02-22 19:50 ` mpolacek at gcc dot gnu.org 2023-02-22 20:06 ` jakub at gcc dot gnu.org 2023-02-22 20:14 ` mpolacek at gcc dot gnu.org 2023-02-22 20:46 ` jakub at gcc dot gnu.org 2023-02-22 20:51 ` mpolacek at gcc dot gnu.org 2023-02-22 22:47 ` cvs-commit at gcc dot gnu.org 2023-02-22 22:48 ` [Bug c/108880] [11/12 " mpolacek at gcc dot gnu.org 2023-03-04 18:02 ` cvs-commit at gcc dot gnu.org 2023-03-07 17:45 ` [Bug c/108880] [11 " mpolacek at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-108880-4-UAOALlVRI4@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).