public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/108898] [13 Regression] Test introduced by r13-6278-g3da77f217c8b2089ecba3eb201e727c3fcdcd19d failed on i386
Date: Tue, 21 Mar 2023 12:29:58 +0000	[thread overview]
Message-ID: <bug-108898-4-KB212loAFr@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108898-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108898

--- Comment #5 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:b49aedf6aed4911c8473738a88e839703f51386d

commit r13-6784-gb49aedf6aed4911c8473738a88e839703f51386d
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Mar 21 13:28:50 2023 +0100

    testsuite: Fix up vect-simd-clone1[678]*.c tests [PR108898]

    As mentioned in the PR, vect-simd-clone-1[678]{,f}.c tests FAIL on
    x86_64-linux with -m64/-march=cascadelake or -m32/-march=cascadelake,
    there are 3 matches for the calls rather than expected two.
    As suggested by Richi, this patch changes those tests to use
    --param vect-epilogues-nomask=0 such that it is more predictable on how
    many calls will show up.  In the non-[a-f] suffixed tests, the
    scan-tree-dump-times patterns were expecting 2 for non-aarch64 and 3 for
    aarch64, which is a puzzle for me, because vect_simd_clones effective
    target is apparently never true on aarch64 (just on x86 in some cases and
    on amdgcn; perhaps something to change for GCC14, but I guess too late
    for stage4).  That said, I have looked at aarch64 dumps and see only 2
    calls with --param vect-epilogues-nomask=0 and 3 with --param
    vect-epilogues-nomask=1 or without it, so I have tweaked those to always
    expect the same thing.  Another thing is some tests uselessly had
    -fdump-tree-optimized in dg-options even when they don't scan anything
    there.

    Tested on x86_64-linux with
    make -j32 -k check-gcc
RUNTESTFLAGS="vect.exp=gcc.dg/vect/vect-simd-clone-*.c \
   
--target_board='unix{-m64/-march=x86-64,-m64/-march=cascadelake,-m32/-march=i686,-m32/-march=cascadelake}'"
    and aarch64-linux (where all tests are UNSUPPORTED before/after).

    2023-03-21  Jakub Jelinek  <jakub@redhat.com>

            PR testsuite/108898
            * gcc.dg/vect/vect-simd-clone-16.c: Add --param
vect-epilogues-nomask=0
            to dg-additional-options.  Always expect just 2 foo.simdclone
calls.
            * gcc.dg/vect/vect-simd-clone-16f.c: Add
            --param vect-epilogues-nomask=0 to dg-additional-options.
            * gcc.dg/vect/vect-simd-clone-17.c: Likewise.  Always expect just 2
            foo.simdclone calls.
            * gcc.dg/vect/vect-simd-clone-17d.c: Remove -fdump-tree-optimized
from
            dg-additional-options.
            * gcc.dg/vect/vect-simd-clone-17e.c: Likewise.
            * gcc.dg/vect/vect-simd-clone-17f.c: Likewise.  Add
            --param vect-epilogues-nomask=0 to dg-additional-options.
            * gcc.dg/vect/vect-simd-clone-18.c: Add --param
vect-epilogues-nomask=0
            to dg-additional-options.  Always expect just 2 foo.simdclone
calls.
            * gcc.dg/vect/vect-simd-clone-18f.c: Add
            --param vect-epilogues-nomask=0 to dg-additional-options.

  parent reply	other threads:[~2023-03-21 12:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23  6:28 [Bug testsuite/108898] New: " haochen.jiang at intel dot com
2023-02-23  8:47 ` [Bug testsuite/108898] " rguenth at gcc dot gnu.org
2023-02-23  9:21 ` ams at gcc dot gnu.org
2023-02-24  1:30 ` haochen.jiang at intel dot com
2023-03-15  9:57 ` rguenth at gcc dot gnu.org
2023-03-15 10:43 ` ams at gcc dot gnu.org
2023-03-21 12:29 ` cvs-commit at gcc dot gnu.org [this message]
2023-03-21 12:31 ` jakub at gcc dot gnu.org
2023-03-21 12:44 ` cvs-commit at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108898-4-KB212loAFr@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).