From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 0F0343858033; Thu, 23 Feb 2023 16:18:53 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F0343858033 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1677169133; bh=I5Mcn9Mlkai52JjxIguLYKKZX5tn8UkSEMt7WlSbva4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=jfm78NpSYP4pSFm4dlJuKtD0C3C+PuEuW87oV+gnRxNiyUM+Gjqmq9Ifx4cPVlqKH Rp5LWYiVnAD91BQooIx2UbA892POVt3QehSIi5HztWEg3G/GCcD+j0NBGYJW4CTK0p 8yQBIcg1ffZBMJL7NOTpT7qhFhkS7OdXZjPjP0q8= From: "cvs-commit at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug testsuite/108899] [13 Regression] ERROR: can't rename to "saved-unsupported": command already exists on i386 Date: Thu, 23 Feb 2023 16:18:50 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: testsuite X-Bugzilla-Version: 13.0 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: cvs-commit at gcc dot gnu.org X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: 13.0 X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108899 --- Comment #7 from CVS Commits --- The master branch has been updated by Jakub Jelinek : https://gcc.gnu.org/g:5592679df783547049efc6d73727c5ff809ec302 commit r13-6306-g5592679df783547049efc6d73727c5ff809ec302 Author: Jakub Jelinek Date: Thu Feb 23 17:17:05 2023 +0100 testsuite: Fix up modules.exp [PR108899] On Wed, Feb 22, 2023 at 02:33:42PM -0300, Alexandre Oliva via Gcc-patch= es wrote: > When a multi-source module is found to be unsupported, we fail > module_cmi_p and subsequent sources. Override proc unsupported to > mark the result in module_do, and test it to skip module_cmp_p and > subsequent related tests. > > for gcc/testsuite/ChangeLog > > * g++.dg/modules/modules.exp: Override unsupported to update > module_do, and test it after dg-test. This patch breaks testing with more than one set of options in target board, like make check-g++ RUNTESTFLAGS=3D'--target_board=3Dunix\{-m32,-m64\} modul= es.exp' yields: ... =3D=3D=3D g++ Summary for unix/-m32 =3D=3D=3D # of expected passes 7217 # of unexpected failures 1 # of expected failures 18 # of unsupported tests 2 Running target unix/-m64 ... ERROR: tcl error sourcing /home/jakub/src/gcc/gcc/testsuite/g++.dg/modules/modules.exp. ERROR: tcl error code TCL OPERATION RENAME TARGET_EXISTS ERROR: can't rename to "saved-unsupported": command already exists while executing "rename unsupported saved-unsupported" (file "/home/jakub/src/gcc/gcc/testsuite/g++.dg/modules/modules.ex= p" line 322) invoked from within "source /home/jakub/src/gcc/gcc/testsuite/g++.dg/modules/modules.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source /home/jakub/src/gcc/gcc/testsuite/g++.dg/modules/modules.exp" invoked from within "catch "uplevel #0 source $test_file_name" msg" In other spots where we in *.exp files rename some routine, we guard th= at and the following patch does that for modules.exp too. Tested with running make check-g++ RUNTESTFLAGS=3D'--target_board=3Dunix\{-m32,-m64\} modul= es.exp' again which now works properly again. 2023-02-23 Jakub Jelinek PR testsuite/108899 * g++.dg/modules/modules.exp: Only override unsupported if it exists and saved-unsupported doesn't.=