From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 1B5CC3857727; Fri, 14 Apr 2023 20:51:18 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1B5CC3857727
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1681505478;
	bh=110S/uVeiEPZaHUeMYodkZNmZKiRcyVNdJ8B/jRo0ak=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=Lyn7H/oRPOZmb0CHIO905RfmGJpGEn3e5aQRX95TUXsDY732sVnPGVGLpPsYWVoLx
	 pqo+F0dZNp1JphCx/egzN6ASXcYNZxKmuuwqHKvTi59GPqaCoynPUYhSF+TVl4/SpF
	 6NOWkottcf3eGAqtYpzTwCdZ8F+HwFaUU3nwA+N0=
From: "jason at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/108910] [12 Regression] Further ICE in
 aarch64_layout_arg
Date: Fri, 14 Apr 2023 20:51:15 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: target
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ice-on-valid-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: jason at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: rsandifo at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 12.3
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-108910-4-2gB1wsbOPd@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-108910-4@http.gcc.gnu.org/bugzilla/>
References: <bug-108910-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D108910

--- Comment #18 from Jason Merrill <jason at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #13)
> Jason, any thoughts on why we for build_type_attribute_qual_variant call
> build_distinct_type_copy rather than build_variant_type_copy

That does seem weird.  It should probably depend on whether any of the
attributes have affects_type_identity.  And so should setting of
TYPE_CANONICAL.  Unless we never use it with such attributes, in which case=
 we
should checking_assert that, and always use build_variant_type_copy.=