public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/108915] invalid pointer access preserved in optimized code
Date: Fri, 24 Feb 2023 04:36:40 +0000	[thread overview]
Message-ID: <bug-108915-4-547lCOqrtl@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108915-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108915

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
static char start_bar[0]
says this is an array of size 0.

The reduced testcase does not match up with the code in uboot though.

Anyways GCC is correct for the reduced testcase, so is clang since it is
undefined as you are accessing outside of the bounds of the array.

The way to fix uboot code is to change the ll_entry_start/ll_entry_end to:


#define ll_entry_start(_type, _list)                                    \
({                                                                      \
        static char start[0] __aligned(CONFIG_LINKER_LIST_ALIGN)        \
                __attribute__((unused))                                 \
                __section("__u_boot_list_2_"#_list"_1");                \
        _type * tmp = (_type *)&start;                                  \
        asm("":"+r"(tmp));                                              \
        tmp;                                                            \
})


#define ll_entry_end(_type, _list)                                      \
({                                                                      \
        static char end[0] __aligned(4) __attribute__((unused))         \
                __section("__u_boot_list_2_"#_list"_3");                       
\
        _type * tmp = (_type *)&end;                                    \
        asm("":"+r"(tmp));                                              \
        tmp;                                                            \
})

  reply	other threads:[~2023-02-24  4:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24  3:47 [Bug c/108915] New: " hiraditya at msn dot com
2023-02-24  4:36 ` pinskia at gcc dot gnu.org [this message]
2023-02-24  4:37 ` [Bug tree-optimization/108915] " pinskia at gcc dot gnu.org
2023-02-24  4:39 ` pinskia at gcc dot gnu.org
2023-02-24  4:55 ` hiraditya at msn dot com
2023-02-24  5:06 ` pinskia at gcc dot gnu.org
2023-03-23 22:27 ` hiraditya at msn dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108915-4-547lCOqrtl@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).