public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/108955] Ultimate++ fails with its specialized AssertMoveable
Date: Mon, 27 Feb 2023 20:32:05 +0000	[thread overview]
Message-ID: <bug-108955-4-8cMOLOyja6@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-108955-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108955

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|WAITING                     |RESOLVED

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
The code is definitely invalid.

How to fix it is to move this:
template <class T>
inline void AssertMoveable(T *t = 0) { if(t) AssertMoveable0(t); }


Below the definitions of AssertMoveable0.
 (__GNUC__ < 4 || __GNUC_MINOR__ < 1)

That is check is just wrong. Especially while GCC 13.0.1 is a stage 4 compiler.

Maybe it should be just:
__GNUC__ < 4 || (__GNUC__ == 4 && __GNUC_MINOR__ < 4)

  parent reply	other threads:[~2023-02-27 20:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 19:56 [Bug c++/108955] New: " piotr5 at netscape dot net
2023-02-27 20:03 ` [Bug c++/108955] " pinskia at gcc dot gnu.org
2023-02-27 20:19 ` piotr5 at netscape dot net
2023-02-27 20:32 ` pinskia at gcc dot gnu.org [this message]
2023-02-27 20:36 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-108955-4-8cMOLOyja6@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).