public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/109011] missed optimization in presence of __builtin_ctz Date: Wed, 19 Apr 2023 09:15:15 +0000 [thread overview] Message-ID: <bug-109011-4-SCWYHiinGt@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109011-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109011 --- Comment #20 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:ade0a1ee5c6707b950ba284adcfed0514866c12d commit r14-65-gade0a1ee5c6707b950ba284adcfed0514866c12d Author: Jakub Jelinek <jakub@redhat.com> Date: Wed Apr 19 11:14:23 2023 +0200 tree-vect-patterns: Improve __builtin_{clz,ctz,ffs}ll vectorization [PR109011] For __builtin_popcountll tree-vect-patterns.cc has vect_recog_popcount_pattern, which improves the vectorized code. Without that the vectorization is always multi-type vectorization in the loop (at least int and long long types) where we emit two .POPCOUNT calls with long long arguments and int return value and then widen to long long, so effectively after vectorization do the V?DImode -> V?DImode popcount twice, then pack the result into V?SImode and immediately unpack. The following patch extends that handling to __builtin_{clz,ctz,ffs}ll builtins as well (as long as there is an optab for them; more to come laster). x86 can do __builtin_popcountll with -mavx512vpopcntdq, __builtin_clzll with -mavx512cd, ppc can do __builtin_popcountll and __builtin_clzll with -mpower8-vector and __builtin_ctzll with -mpower9-vector, s390 can do __builtin_{popcount,clz,ctz}ll with -march=z13 -mzarch (i.e. VX). 2023-04-19 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/109011 * tree-vect-patterns.cc (vect_recog_popcount_pattern): Rename to ... (vect_recog_popcount_clz_ctz_ffs_pattern): ... this. Handle also CLZ, CTZ and FFS. Remove vargs variable, use gimple_build_call_internal rather than gimple_build_call_internal_vec. (vect_vect_recog_func_ptrs): Adjust popcount entry. * gcc.dg/vect/pr109011-1.c: New test.
next prev parent reply other threads:[~2023-04-19 9:15 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-03 14:56 [Bug tree-optimization/109011] New: " vincenzo.innocente at cern dot ch 2023-03-03 19:45 ` [Bug tree-optimization/109011] " pinskia at gcc dot gnu.org 2023-03-03 19:48 ` pinskia at gcc dot gnu.org 2023-03-03 20:21 ` jakub at gcc dot gnu.org 2023-03-03 20:39 ` jakub at gcc dot gnu.org 2023-03-03 20:46 ` jakub at gcc dot gnu.org 2023-03-04 0:18 ` jakub at gcc dot gnu.org 2023-03-04 11:14 ` jakub at gcc dot gnu.org 2023-03-04 12:22 ` jakub at gcc dot gnu.org 2023-03-04 14:01 ` jakub at gcc dot gnu.org 2023-03-04 15:08 ` jakub at gcc dot gnu.org 2023-03-06 5:26 ` crazylht at gmail dot com 2023-03-06 7:01 ` jakub at gcc dot gnu.org 2023-03-06 7:59 ` crazylht at gmail dot com 2023-03-06 8:11 ` jakub at gcc dot gnu.org 2023-03-06 8:23 ` crazylht at gmail dot com 2023-03-06 8:32 ` jakub at gcc dot gnu.org 2023-03-06 9:22 ` jakub at gcc dot gnu.org 2023-03-14 9:24 ` crazylht at gmail dot com 2023-03-16 6:32 ` crazylht at gmail dot com 2023-04-19 9:15 ` cvs-commit at gcc dot gnu.org [this message] 2023-04-20 9:56 ` cvs-commit at gcc dot gnu.org 2023-04-20 17:45 ` cvs-commit at gcc dot gnu.org 2023-04-24 1:35 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109011-4-SCWYHiinGt@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).