From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 6C89238582B0; Fri, 17 Mar 2023 14:39:48 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6C89238582B0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1679063988;
	bh=BewIJzI2KfnOrR5F8qdhuazHlF3zs20Ea5AcHvJHFbY=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=U0nxfb8FFc2paodWBRwBMaiG3UBMsHWg9C3Y8adOezv22p7vEJtwBh3GwJVh96t0r
	 T7VUHp5LzcFEnoszEayTm5usZx+/xodrWMHO1nCXt7i3h/gIDO49pZbZVVsJdd10Jg
	 LSYhOtXWrtbIFDYdYJsu6fUSi+z56UtuQyJ80TnE=
From: "vmakarov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug rtl-optimization/109052] Unnecessary reload with -mfpmath=both
Date: Fri, 17 Mar 2023 14:39:48 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: rtl-optimization
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: ra
X-Bugzilla-Severity: normal
X-Bugzilla-Who: vmakarov at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109052-4-Uz9e2SH18n@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109052-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109052-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109052

--- Comment #6 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
(In reply to Uro=C5=A1 Bizjak from comment #5)
> (In reply to Vladimir Makarov from comment #4)
>=20
> > So I think the current patch is probably an adequate solution.
>=20
> Perhaps the compiler should also try to swap input operands to fit the
> combined insn when commutative operands are allowed. This would solve the
> testcase from Comment #2:
>=20

Yes.  I am agree.  The base code can be improved further.
Another improvement could be combining secondary memory reload for output.

I'd like to watch what the effect of the current patch would be first.=20=20
Although I tested the patch on many targets as usually for LRA the patch mi=
ght
result in some troubles on some targets.  But I hope nothing bad will happe=
n.=