From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 48) id 2AAA33858C20; Tue, 7 Mar 2023 15:53:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2AAA33858C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678204403; bh=g6/5ugJVYyb62+xYmjGKefsdFqNUHYmi6bR67L8iFr4=; h=From:To:Subject:Date:In-Reply-To:References:From; b=H7bxfVeaMfWLqIgc0iiMpzNO6g+YaD0VY2JHhkg8t5Gu3xy2Q6pNd2E0WsddfEvaK kxA4BCmqleQSV/xTZLh+ZlCFQwztwtcOhb3Gj17KOn52uuO7BBL+v2NkCkfwvL6Mn3 eBiLNeaZvCaKTmVXjym3FX4qC5kf/cIC9QZc6UzI= From: "jakub at gcc dot gnu.org" To: gcc-bugs@gcc.gnu.org Subject: [Bug libgcc/109054] _Unwind_GetLanguageSpecificData should have protected visibility Date: Tue, 07 Mar 2023 15:53:22 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: gcc X-Bugzilla-Component: libgcc X-Bugzilla-Version: unknown X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: jakub at gcc dot gnu.org X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P3 X-Bugzilla-Assigned-To: unassigned at gcc dot gnu.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 List-Id: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109054 Jakub Jelinek changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jakub at gcc dot gnu.org --- Comment #1 from Jakub Jelinek --- Protected visibility is always wrong, it is broken by design (or lack there= of). The _Unwind_* APIs are required by the Itanium ABI, and we call various oth= er such functions from libgcc code already (e.g. _Unwind_Find_FDE from _Unwind_FindEnclosingFunction and uw_frame_state_for and others, _Unwind_GetTextRelBase, _Unwind_GetRegionStart, _Unwind_GetDataRelBase, _Unwind_SetGR, _Unwind_SetIP, _Unwind_GetIPInfo and _Unwind_GetCFA from various spots, _Unwind_RaiseException from _Unwind_Resume_or_Rethrow etc.). It is IMHO very bad idea to have 2 different unwinders in the same process = with the same exported functions. If you'd like libgcc to call local aliases of these functions instead of th= ose functions, I'm afraid it could break various things, e.g. i?86 glibc exports _Unwind_Find_FDE too and we rely on a single registry for all unwinding.=