public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "dmalcolm at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/109058] RFE: analyzer should elide repeated calls to strcmp in execution paths
Date: Tue, 07 Mar 2023 18:30:48 +0000	[thread overview]
Message-ID: <bug-109058-4-lqokjxs2dx@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109058-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109058

--- Comment #1 from David Malcolm <dmalcolm at gcc dot gnu.org> ---
Even better would be for the event condition to express the string, when it's a
string literal, so that it reads:

../../src/gcc/testsuite/gcc.dg/analyzer/strcmp-path-1.c:27:5: note: path
   27 |     __analyzer_dump_path ();
      |     ^~~~~~~~~~~~~~~~~~~~~~~
  ‘test’: events 1-3
    |
    |   25 |   } else if (strcmp (args[0], "opt-010") == 0) {
    |      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    |      |             |
    |      |             (1) following ‘true’ branch (when args[0] is
"opt-010")...
    |   26 |     do_opt (10);
    |      |     ~~~~~~~~~~~
    |      |     |
    |      |     (2) ...to here
    |   27 |     __analyzer_dump_path ();
    |      |     ~~~~~~~~~~~~~~~~~~~~~~~
    |      |     |
    |      |     (3) here
    |

  reply	other threads:[~2023-03-07 18:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 18:14 [Bug analyzer/109058] New: " dmalcolm at gcc dot gnu.org
2023-03-07 18:30 ` dmalcolm at gcc dot gnu.org [this message]
2023-03-08 22:20 ` [Bug analyzer/109058] " dmalcolm at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109058-4-lqokjxs2dx@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).