public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "linkw at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug target/109069] [12/13 Regression] Vector truncation test program produces incorrect result since r12-6537-g080a06fcb076b3 Date: Fri, 10 Mar 2023 09:58:51 +0000 [thread overview] Message-ID: <bug-109069-4-JaOrSFsG0i@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109069-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109069 Kewen Lin <linkw at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Vector truncation test |[12/13 Regression] Vector |program produces incorrect |truncation test program |result on big-endian |produces incorrect result |powerpc64-linux-gnu with |since |-mcpu=power10 -O2 |r12-6537-g080a06fcb076b3 Known to work| |11.3.0 --- Comment #7 from Kewen Lin <linkw at gcc dot gnu.org> --- One test case can be: #include <altivec.h> __attribute__ ((noipa)) vector signed int test () { vector signed int v = {-16, -16, -16, -16}; vector signed int res = vec_sld (v, v, 3); return res; } int main () { vector signed int res = test (); if (res[0] != 0xf0ffffff) __builtin_abort (); return 0; } It fails on Power7,8,9,10. It starts to fail from r12-6537-g080a06fcb076b3, when the two input operands are the same, it's only safe to optimize it into a vector move no matter what's the shift count is that the given vector is a const vec_duplicate and the duplicated element is affordable in a byte. The culprit commit is incorrect to use easy_vector_constant as predicate, which just guards those vector constants without memory loading. The reason why the reporter only saw this on Power10 is that the given constant 0xFA578D00u can only satisfy "easy_vector_constant" till power10. The constructed test case above adopts one constant which can be built with vspltisw, then we can easily see the failure.
next prev parent reply other threads:[~2023-03-10 9:58 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-08 21:00 [Bug target/109069] New: Vector truncation test program produces incorrect result on big-endian powerpc64-linux-gnu with -mcpu=power10 -O2 john_platts at hotmail dot com 2023-03-08 21:17 ` [Bug target/109069] " john_platts at hotmail dot com 2023-03-09 12:45 ` linkw at gcc dot gnu.org 2023-03-09 15:41 ` john_platts at hotmail dot com 2023-03-09 15:53 ` john_platts at hotmail dot com 2023-03-09 16:45 ` john_platts at hotmail dot com 2023-03-10 7:03 ` linkw at gcc dot gnu.org 2023-03-10 9:58 ` linkw at gcc dot gnu.org [this message] 2023-03-15 10:02 ` [Bug target/109069] [12/13 Regression] Vector truncation test program produces incorrect result since r12-6537-g080a06fcb076b3 rguenth at gcc dot gnu.org 2023-04-26 5:22 ` [Bug target/109069] [12/13/14 " cvs-commit at gcc dot gnu.org 2023-05-08 12:26 ` [Bug target/109069] [12/13 " rguenth at gcc dot gnu.org 2023-05-09 5:18 ` cvs-commit at gcc dot gnu.org 2023-05-09 8:29 ` cvs-commit at gcc dot gnu.org 2023-05-09 8:33 ` linkw at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109069-4-JaOrSFsG0i@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).