public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "qinzhao at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/109071] -Warray-bounds false positive warnings due to code duplication from jump threading Date: Mon, 13 May 2024 14:21:30 +0000 [thread overview] Message-ID: <bug-109071-4-tAXQ6VWNo1@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109071-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109071 --- Comment #10 from qinzhao at gcc dot gnu.org --- with the following added heuristic in array-bound checker: + /* If the stmt is duplicated and splitted, the warning level is not 2, + and the current block is not dominating the exit block, not report + the warning. */ + if (is_splitted && warn_array_bounds < 2 + && !is_dominate_exit) + return false; + such false positive warnings are moved from -Warray-bound=1 to -Warray-bound=2. [opc@qinzhao-ol8u3-x86 109071]$ /home/opc/Install/latest-d/bin/gcc -O2 -Warray-bounds=2 -c -o t.o t.c t.c: In function ‘sparx5_set’: t.c:12:29: warning: array subscript 4 is above array bounds of ‘int[4]’ [-Warray-bounds=] 12 | int *val = &sg->vals[index]; | ~~~~~~~~^~~~~~~ t.c:8:18: note: while referencing ‘vals’ 8 | struct nums {int vals[4];}; | ^~~~ [opc@qinzhao-ol8u3-x86 109071]$ /home/opc/Install/latest-d/bin/gcc -O2 -Warray-bounds=1 -c -o t.o t.c [opc@qinzhao-ol8u3-x86 109071]$
next prev parent reply other threads:[~2024-05-13 14:21 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-08 21:04 [Bug c/109071] New: -Warray-bounds warning when array index checked via inline kees at outflux dot net 2023-03-08 21:13 ` [Bug tree-optimization/109071] " pinskia at gcc dot gnu.org 2023-03-09 10:18 ` rguenth at gcc dot gnu.org 2023-03-09 16:15 ` kees at outflux dot net 2023-03-10 15:51 ` qinzhao at gcc dot gnu.org 2024-04-22 19:12 ` [Bug tree-optimization/109071] -Warray-bounds false positive warnings due to code duplication from jump threading qinzhao at gcc dot gnu.org 2024-04-22 19:21 ` kees at outflux dot net 2024-04-22 20:04 ` qinzhao at gcc dot gnu.org 2024-04-22 20:15 ` kees at outflux dot net 2024-04-22 21:19 ` qinzhao at gcc dot gnu.org 2024-05-13 14:21 ` qinzhao at gcc dot gnu.org [this message] 2024-05-14 16:19 ` qinzhao at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109071-4-tAXQ6VWNo1@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).