public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/109088] GCC does not always vectorize conditional reduction Date: Wed, 15 Nov 2023 14:42:45 +0000 [thread overview] Message-ID: <bug-109088-4-IORyqQQql9@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109088-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109088 --- Comment #20 from rguenther at suse dot de <rguenther at suse dot de> --- On Wed, 15 Nov 2023, juzhe.zhong at rivai dot ai wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109088 > > --- Comment #19 from JuzheZhong <juzhe.zhong at rivai dot ai> --- > I have added: > > + if (!ANY_INTEGRAL_TYPE_P (TREE_TYPE (PHI_RESULT (phi))) For TYPE_OVERFLOW_UNDEFINED you have to convert the ops to unsigned to avoid spurious undefined overflow. > + && !(FLOAT_TYPE_P (TREE_TYPE (PHI_RESULT (phi))) > + && !HONOR_SIGNED_ZEROS (TREE_TYPE (PHI_RESULT (phi))) > + && !HONOR_SIGN_DEPENDENT_ROUNDING (TREE_TYPE (PHI_RESULT (phi))) > + && !HONOR_NANS (TREE_TYPE (PHI_RESULT (phi))))) You should check flag_associative_math which covers one half and !flag_trapping_math which covers spurious FP exceptions. > + return false; > > for floating-point. I failed to see which situation will cause FP exceptions ? Ops with NaN cause INVALID, but there's also INEXACT which can be set differently after re-association.
next prev parent reply other threads:[~2023-11-15 14:42 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-10 9:24 [Bug c/109088] New: GCC fail auto-vectorization juzhe.zhong at rivai dot ai 2023-03-10 10:39 ` [Bug c/109088] " ubizjak at gmail dot com 2023-03-10 12:39 ` [Bug tree-optimization/109088] " rguenth at gcc dot gnu.org 2023-03-10 13:16 ` juzhe.zhong at rivai dot ai 2023-03-10 14:04 ` pinskia at gcc dot gnu.org 2023-03-10 14:09 ` [Bug tree-optimization/109088] GCC does not always vectorize conditional reduction pinskia at gcc dot gnu.org 2023-09-26 12:14 ` juzhe.zhong at rivai dot ai 2023-09-27 2:45 ` juzhe.zhong at rivai dot ai 2023-09-27 2:58 ` juzhe.zhong at rivai dot ai 2023-09-27 7:15 ` rguenth at gcc dot gnu.org 2023-09-27 7:34 ` juzhe.zhong at rivai dot ai 2023-09-27 9:06 ` rguenth at gcc dot gnu.org 2023-09-27 9:27 ` juzhe.zhong at rivai dot ai 2023-09-27 14:11 ` juzhe.zhong at rivai dot ai 2023-10-06 9:44 ` rguenth at gcc dot gnu.org 2023-11-10 12:02 ` juzhe.zhong at rivai dot ai 2023-11-10 13:10 ` rguenth at gcc dot gnu.org 2023-11-10 13:42 ` juzhe.zhong at rivai dot ai 2023-11-15 14:09 ` rguenth at gcc dot gnu.org 2023-11-15 14:38 ` juzhe.zhong at rivai dot ai 2023-11-15 14:42 ` rguenther at suse dot de [this message] 2023-11-16 1:06 ` juzhe.zhong at rivai dot ai 2023-11-16 6:50 ` rguenther at suse dot de
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109088-4-IORyqQQql9@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).