[Bug other/109103] New: Missing function internal_error

public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed

* [Bug other/109103] New: Missing function internal_error_at
@ 2023-03-11  6:21 roland.illig at gmx dot de
  2023-03-13 13:50 ` [Bug modula2/109103] " gaius at gcc dot gnu.org
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: roland.illig at gmx dot de @ 2023-03-11  6:21 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109103

            Bug ID: 109103
           Summary: Missing function internal_error_at
           Product: gcc
           Version: 13.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: other
          Assignee: unassigned at gcc dot gnu.org
          Reporter: roland.illig at gmx dot de
  Target Milestone: ---

m2expr.c says:
> error_at (
>     location,
>     "internal error: not expecting operand1 to be a constant set");

This should rather be a call to internal_error_at, but that function does not
exist yet. For symmetry with the other error reporting functions, it should be
added.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug modula2/109103] Missing function internal_error_at
  2023-03-11  6:21 [Bug other/109103] New: Missing function internal_error_at roland.illig at gmx dot de
@ 2023-03-13 13:50 ` gaius at gcc dot gnu.org
  2023-03-13 14:43 ` gaius at gcc dot gnu.org
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-03-13 13:50 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109103

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2023-03-13
     Ever confirmed|0                           |1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug modula2/109103] Missing function internal_error_at
  2023-03-11  6:21 [Bug other/109103] New: Missing function internal_error_at roland.illig at gmx dot de
  2023-03-13 13:50 ` [Bug modula2/109103] " gaius at gcc dot gnu.org
@ 2023-03-13 14:43 ` gaius at gcc dot gnu.org
  2023-03-13 23:03 ` cvs-commit at gcc dot gnu.org
  2023-03-13 23:06 ` gaius at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-03-13 14:43 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109103

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 54649
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54649&action=edit
Proposed fix

Here is a proposed patch.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug modula2/109103] Missing function internal_error_at
  2023-03-11  6:21 [Bug other/109103] New: Missing function internal_error_at roland.illig at gmx dot de
  2023-03-13 13:50 ` [Bug modula2/109103] " gaius at gcc dot gnu.org
  2023-03-13 14:43 ` gaius at gcc dot gnu.org
@ 2023-03-13 23:03 ` cvs-commit at gcc dot gnu.org
  2023-03-13 23:06 ` gaius at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-03-13 23:03 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109103

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:370298f493020eeff48bc2e56463c1097ed67b1d

commit r13-6649-g370298f493020eeff48bc2e56463c1097ed67b1d
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Mon Mar 13 23:03:24 2023 +0000

    PR 109103 Modula2 Missing function internal_error_at

    m2expr.cc should call to internal_error_at, but that function
    does not exist yet.  For symmetry with the other error reporting
    functions, it should be added.  This patch provides this function
    and also corrects obvious bool/int parameter mismatches in
    m2options.h and m2expr.h.

    gcc/m2/ChangeLog:

            PR modula2/109103
            * gm2-compiler/M2ALU.def (PushString): New parameter issueError.
            * gm2-compiler/M2ALU.mod (PushString): New parameter issueError.
            * gm2-compiler/SymbolTable.mod (PushString): New parameter
issueError.
            * gm2-gcc/m2decl.cc (m2decl_DetermineSizeOfConstant): Pass
            location to interpret_m2_integer.
            (m2decl_BuildConstLiteralNumber): New parameter issueError.
            * gm2-gcc/m2expr.cc (m2expr_IsTrue): Replace int with bool.
            (m2expr_IsFalse): Replace int with bool.
            (m2expr_AreConstantsEqual): Replace int with bool.
            (m2expr_BuildBinaryForeachWordDo): Call
m2linemap_internal_error_at.
            (append_digit): Ditto.
            (m2expr_interpret_integer): Add location parameter.
            (append_m2_digit): Call m2linemap_internal_error_at.
            (m2expr_interpret_m2_integer): Add location parameter.
            (m2expr_GetSizeOf): Replace sizeof with SIZE in error message.
            * gm2-gcc/m2expr.h (m2expr_AreRealOrComplexConstantsEqual):
            Replace int with bool.
            (m2expr_AreConstantsEqual): Ditto.
            (m2expr_IsFalse): Ditto.
            (m2expr_IsTrue): Ditto.
            (m2expr_interpret_integer): Add location parameter.
            (m2expr_interpret_m2_integer): Add location parameter.
            * gm2-gcc/m2linemap.cc (mformat_value): New function.
            (expand_format): New function.
            (expand_message): New function.
            (gm2_internal_error_at): New function.
            (m2linemap_internal_error_at): New function.
            * gm2-gcc/m2linemap.h (m2linemap_internal_error_at): New function.
            * gm2-gcc/m2options.h (M2Options_SetISO): Replace int with bool.
            (M2Options_SetPIM): Ditto.
            (M2Options_SetPIM2): Ditto.
            (M2Options_SetPIM3): Ditto.
            (M2Options_SetPIM4): Ditto.
            (M2Options_SetFloatValueCheck): Ditto.
            (M2Options_SetWholeValueCheck): Ditto.
            (M2Options_GetISO): Ditto.
            (M2Options_GetPIM): Ditto.
            (M2Options_GetPIM2): Ditto.
            (M2Options_GetPIM3): Ditto.
            (M2Options_GetPIM4): Ditto.
            (M2Options_GetPositiveModFloor): Ditto.
            (M2Options_GetFloatValueCheck): Ditto.
            (M2Options_GetWholeValueCheck): Ditto.
            (M2Options_Setc): Ditto.
            (M2Options_Getc): Ditto.
            (M2Options_SetPPOnly): Ditto.
            (M2Options_GetPPOnly): Ditto.
            (M2Options_SetUselist): Ditto.
            (M2Options_SetAutoInit): Ditto.
            (M2Options_SetPositiveModFloor): Ditto.
            (M2Options_SetNilCheck): Ditto.
            (M2Options_SetWholeDiv): Ditto.
            (M2Options_SetIndex): Ditto.
            (M2Options_SetRange): Ditto.
            (M2Options_SetReturnCheck): Ditto.
            (M2Options_SetCaseCheck): Ditto.
            (M2Options_SetCheckAll): Ditto.
            (M2Options_SetExceptions): Ditto.
            (M2Options_SetStyle): Ditto.
            (M2Options_SetPedantic): Ditto.
            (M2Options_SetPedanticParamNames): Ditto.
            (M2Options_SetPedanticCast): Ditto.
            (M2Options_SetExtendedOpaque): Ditto.
            (M2Options_SetVerboseUnbounded): Ditto.
            (M2Options_SetXCode): Ditto.
            (M2Options_SetCompilerDebugging): Ditto.
            (M2Options_SetQuadDebugging): Ditto.
            (M2Options_SetDebugTraceQuad): Ditto.
            (M2Options_SetDebugTraceAPI): Ditto.
            (M2Options_SetSources): Ditto.
            (M2Options_SetUnboundedByReference): Ditto.
            (M2Options_SetDumpSystemExports): Ditto.
            (M2Options_SetOptimizing): Ditto.
            (M2Options_SetQuiet): Ditto.
            (M2Options_SetCC1Quiet): Ditto.
            (M2Options_SetCpp): Ditto.
            (M2Options_SetSwig): Ditto.
            (M2Options_SetWholeProgram): Ditto.
            (M2Options_SetDebugFunctionLineNumbers): Ditto.
            (M2Options_SetGenerateStatementNote): Ditto.
            (M2Options_GetCpp): Ditto.
            (M2Options_GetM2g): Ditto.
            (M2Options_SetM2g): Ditto.
            (M2Options_SetLowerCaseKeywords): Ditto.
            (M2Options_SetVerbose): Ditto.
            (M2Options_SetUnusedVariableChecking): Ditto.
            (M2Options_SetUnusedParameterChecking): Ditto.
            (M2Options_SetStrictTypeChecking): Ditto.
            (M2Options_SetWall): Ditto.
            (M2Options_SetSaveTemps): Ditto.
            (M2Options_GetSaveTemps): Ditto.
            (M2Options_SetScaffoldStatic): Ditto.
            (M2Options_SetScaffoldDynamic): Ditto.
            (M2Options_SetScaffoldMain): Ditto.
            (M2Options_SetGenModuleList): Ditto.
            (M2Options_SetShared): Ditto.
            * gm2-libs-ch/M2LINK.c: Ditto.
            * gm2-libs-ch/m2rts.h (M2RTS_RequestDependant): Replace
            const char * with const void *.
            (M2RTS_RegisterModule): Ditto.
            (M2RTS_ConstructModules): Ditto.
            * gm2-gcc/m2decl.def (DetermineSizeOfConstant): New parameter
            issueError.
            * gm2-gcc/m2decl.h (DetermineSizeOfConstant): New parameter
            issueError.

    gcc/testsuite/ChangeLog:

            * gm2/pim/fail/largeconst.mod: New test.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Bug modula2/109103] Missing function internal_error_at
  2023-03-11  6:21 [Bug other/109103] New: Missing function internal_error_at roland.illig at gmx dot de
                   ` (2 preceding siblings ...)
  2023-03-13 23:03 ` cvs-commit at gcc dot gnu.org
@ 2023-03-13 23:06 ` gaius at gcc dot gnu.org
  3 siblings, 0 replies; 5+ messages in thread
From: gaius at gcc dot gnu.org @ 2023-03-13 23:06 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109103

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Many thanks for the bug report - now fixed.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-03-13 23:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-11  6:21 [Bug other/109103] New: Missing function internal_error_at roland.illig at gmx dot de
2023-03-13 13:50 ` [Bug modula2/109103] " gaius at gcc dot gnu.org
2023-03-13 14:43 ` gaius at gcc dot gnu.org
2023-03-13 23:03 ` cvs-commit at gcc dot gnu.org
2023-03-13 23:06 ` gaius at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).