public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "burnus at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug middle-end/109128] [Offload][OpenMP][OpenACC] Static linking with unused offload function will lead to mismatch number of offload fn/symbols
Date: Tue, 14 Mar 2023 13:07:36 +0000	[thread overview]
Message-ID: <bug-109128-4-S5PAgtnBGw@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109128-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109128

--- Comment #2 from Tobias Burnus <burnus at gcc dot gnu.org> ---
(In reply to Thomas Schwinge from comment #1)
> See also "Allow the accelerator to have more offloaded functions than the host".

Which was:

-  if (num_target_entries != num_funcs + num_vars)
+  if (num_target_entries < num_funcs + num_vars)

I think this approach only works if functions are missing "at the end".
The code does:

gomp_load_image_to_device (..., const void *host_table,
                                const void *target_data, ...)
...
  void **host_func_table = ((void ***) host_table)[0];
  void **host_funcs_end  = ((void ***) host_table)[1];
  int num_funcs = host_funcs_end - host_func_table;
...
  num_target_entries
    = devicep->load_image_func (devicep->target_id, version,
                                target_data, &target_table,
...
      k->host_start = (uintptr_t) host_func_table[i];
...
      k->tgt_offset = target_table[i].start;

Thus, it strictly depends on the order. That is: If some function "in the
middle" is not linked in / part of 'host_table' alias '__OFFLOAD_TABLE__', all
remaining host<->device function and/or variable assignments are messed up.

  parent reply	other threads:[~2023-03-14 13:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 12:15 [Bug middle-end/109128] New: " burnus at gcc dot gnu.org
2023-03-14 12:36 ` [Bug middle-end/109128] " tschwinge at gcc dot gnu.org
2023-03-14 13:07 ` burnus at gcc dot gnu.org [this message]
2023-03-30 14:42 ` burnus at gcc dot gnu.org
2023-03-30 19:12 ` burnus at gcc dot gnu.org
2023-03-30 20:00 ` burnus at gcc dot gnu.org
2023-03-31  8:39 ` tschwinge at gcc dot gnu.org
2023-05-02 17:20 ` burnus at gcc dot gnu.org
2023-05-11  8:09 ` cvs-commit at gcc dot gnu.org
2023-05-11 14:56 ` burnus at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109128-4-S5PAgtnBGw@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).