public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/109154] [13 regression] jump threading de-optimizes nested floating point comparisons Date: Tue, 28 Mar 2023 09:01:06 +0000 [thread overview] Message-ID: <bug-109154-4-gen5yj1n6F@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109154-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109154 --- Comment #23 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:ce3974e5962b0e1f72a1f71ebda39d53a77b7cc9 commit r13-6898-gce3974e5962b0e1f72a1f71ebda39d53a77b7cc9 Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Mar 28 11:00:32 2023 +0200 range-op-float: Only flush_denormals_to_zero for +-*/ [PR109154] As discussed in the PR, flushing denormals to zero on every frange::set might be harmful for e.g. x < 0.0 comparisons, because we then on both sides use ranges that include zero [-Inf, -0.0] on the true side, and [-0.0, +Inf] NAN on the false side, rather than [-Inf, nextafter (-0.0, -Inf)] on the true side. The following patch does it only in range_operator_float::fold_range which is right now used for +-*/ (both normal and reverse ops of those). Though, I don't see any difference on the testcase in the PR, but not sure what I should be looking at and the reduced testcase there has undefined behavior. 2023-03-28 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/109154 * value-range.h (frange::flush_denormals_to_zero): Make it public rather than private. * value-range.cc (frange::set): Don't call flush_denormals_to_zero here. * range-op-float.cc (range_operator_float::fold_range): Call flush_denormals_to_zero.
next prev parent reply other threads:[~2023-03-28 9:01 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-16 11:57 [Bug tree-optimization/109154] New: [13 regression] aarch64 -mcpu=neoverse-v1 microbude performance regression pgodbole at nvidia dot com 2023-03-16 13:11 ` [Bug tree-optimization/109154] " tnfchris at gcc dot gnu.org 2023-03-16 14:58 ` [Bug target/109154] " rguenth at gcc dot gnu.org 2023-03-16 17:03 ` tnfchris at gcc dot gnu.org 2023-03-16 17:03 ` [Bug target/109154] [13 regression] jump threading with de-optimizes nested floating point comparisons tnfchris at gcc dot gnu.org 2023-03-22 10:20 ` [Bug tree-optimization/109154] [13 regression] jump threading " aldyh at gcc dot gnu.org 2023-03-22 10:29 ` avieira at gcc dot gnu.org 2023-03-22 12:22 ` rguenth at gcc dot gnu.org 2023-03-22 12:42 ` rguenth at gcc dot gnu.org 2023-03-22 13:11 ` aldyh at gcc dot gnu.org 2023-03-22 14:00 ` amacleod at redhat dot com 2023-03-22 14:39 ` aldyh at gcc dot gnu.org 2023-03-27 8:09 ` rguenth at gcc dot gnu.org 2023-03-27 9:30 ` jakub at gcc dot gnu.org 2023-03-27 9:42 ` aldyh at gcc dot gnu.org 2023-03-27 9:44 ` jakub at gcc dot gnu.org 2023-03-27 10:18 ` rguenther at suse dot de 2023-03-27 10:40 ` jakub at gcc dot gnu.org 2023-03-27 10:44 ` jakub at gcc dot gnu.org 2023-03-27 10:54 ` rguenth at gcc dot gnu.org 2023-03-27 10:56 ` jakub at gcc dot gnu.org 2023-03-27 10:59 ` jakub at gcc dot gnu.org 2023-03-27 17:07 ` jakub at gcc dot gnu.org 2023-03-28 8:33 ` rguenth at gcc dot gnu.org 2023-03-28 9:01 ` cvs-commit at gcc dot gnu.org [this message] 2023-03-28 10:07 ` tnfchris at gcc dot gnu.org 2023-03-28 10:08 ` tnfchris at gcc dot gnu.org 2023-03-28 12:18 ` jakub at gcc dot gnu.org 2023-03-28 12:25 ` rguenth at gcc dot gnu.org 2023-03-28 12:42 ` rguenth at gcc dot gnu.org 2023-03-28 13:19 ` rguenth at gcc dot gnu.org 2023-03-28 13:44 ` jakub at gcc dot gnu.org 2023-03-28 13:52 ` jakub at gcc dot gnu.org 2023-03-28 15:31 ` amacleod at redhat dot com 2023-03-28 15:40 ` jakub at gcc dot gnu.org 2023-03-28 15:53 ` amacleod at redhat dot com 2023-03-28 15:58 ` jakub at gcc dot gnu.org 2023-03-28 16:42 ` amacleod at redhat dot com 2023-03-28 21:12 ` amacleod at redhat dot com 2023-03-29 6:33 ` cvs-commit at gcc dot gnu.org 2023-03-29 6:38 ` rguenth at gcc dot gnu.org 2023-03-29 22:41 ` amacleod at redhat dot com 2023-03-30 18:17 ` cvs-commit at gcc dot gnu.org 2023-04-05 9:28 ` tnfchris at gcc dot gnu.org 2023-04-05 9:34 ` ktkachov at gcc dot gnu.org 2023-04-11 9:36 ` rguenth at gcc dot gnu.org 2023-04-13 16:54 ` jakub at gcc dot gnu.org 2023-04-13 17:25 ` rguenther at suse dot de 2023-04-13 17:29 ` jakub at gcc dot gnu.org 2023-04-14 18:10 ` jakub at gcc dot gnu.org 2023-04-14 18:14 ` jakub at gcc dot gnu.org 2023-04-14 18:22 ` jakub at gcc dot gnu.org 2023-04-14 19:09 ` jakub at gcc dot gnu.org 2023-04-15 10:10 ` cvs-commit at gcc dot gnu.org 2023-04-17 11:07 ` jakub at gcc dot gnu.org 2023-04-25 18:32 ` [Bug tree-optimization/109154] [13/14 " tnfchris at gcc dot gnu.org 2023-04-25 18:34 ` jakub at gcc dot gnu.org 2023-04-26 6:58 ` rguenth at gcc dot gnu.org 2023-04-26 9:43 ` tnfchris at gcc dot gnu.org 2023-04-26 10:07 ` jakub at gcc dot gnu.org 2023-07-07 18:10 ` tnfchris at gcc dot gnu.org 2023-07-10 7:15 ` rguenth at gcc dot gnu.org 2023-07-10 10:33 ` tnfchris at gcc dot gnu.org 2023-07-10 10:46 ` rguenth at gcc dot gnu.org 2023-07-10 11:02 ` tnfchris at gcc dot gnu.org 2023-07-10 11:27 ` rguenth at gcc dot gnu.org 2023-07-10 11:49 ` tnfchris at gcc dot gnu.org 2023-07-14 10:22 ` cvs-commit at gcc dot gnu.org 2023-07-14 10:22 ` cvs-commit at gcc dot gnu.org 2023-07-27 9:25 ` rguenth at gcc dot gnu.org 2023-10-02 10:53 ` cvs-commit at gcc dot gnu.org 2023-10-18 8:54 ` cvs-commit at gcc dot gnu.org 2023-10-18 8:54 ` cvs-commit at gcc dot gnu.org 2023-10-18 8:54 ` cvs-commit at gcc dot gnu.org 2023-10-18 8:55 ` cvs-commit at gcc dot gnu.org 2023-11-09 14:20 ` cvs-commit at gcc dot gnu.org 2023-11-09 14:20 ` cvs-commit at gcc dot gnu.org 2023-11-09 14:20 ` cvs-commit at gcc dot gnu.org 2023-11-09 14:20 ` cvs-commit at gcc dot gnu.org 2023-11-09 14:20 ` cvs-commit at gcc dot gnu.org 2023-11-09 14:20 ` cvs-commit at gcc dot gnu.org 2023-11-09 14:20 ` cvs-commit at gcc dot gnu.org 2023-11-09 14:20 ` cvs-commit at gcc dot gnu.org 2023-11-09 14:25 ` [Bug tree-optimization/109154] [13 " tnfchris at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109154-4-gen5yj1n6F@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).