From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id A21AA3858C52; Mon, 20 Mar 2023 20:54:31 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A21AA3858C52
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1679345671;
	bh=YwpVmCUqLNYn6RivIpHjlYexBCFPanMNlVQUzsTy9+I=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=FdW5U1WFaXjNKD7kMCHNv9Uz77uCnpaE2IgaL9ntwUTQGsiE0HgTq2b2dMx5QNICH
	 7s73/KLrd3uq8clLXYgVO+xoCVnhjw5MKuZXkxo0YVnLkhNXZtjQIZ8fZ0RZE+j+4o
	 ewspEGNNEo6uTpvP2bT2xkrIZ73L2rG09YOScjj8=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/109159] [10/11/12/13 Regression] explicit constructor is
 used in copy-initialization
Date: Mon, 20 Mar 2023 20:54:30 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 12.2.1
X-Bugzilla-Keywords: accepts-invalid
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: mpolacek at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 10.5
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109159-4-bCwpi1M5Rz@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109159-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109159-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109159

--- Comment #4 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Marek Polacek <mpolacek@gcc.gnu.org>:

https://gcc.gnu.org/g:a226590fefb35ed66adf73d85cefe49048a78ab8

commit r13-6765-ga226590fefb35ed66adf73d85cefe49048a78ab8
Author: Marek Polacek <polacek@redhat.com>
Date:   Fri Mar 17 18:25:13 2023 -0400

    c++: explicit ctor and list-initialization [PR109159]

    When I implemented explicit(bool) in r9-3735, I added this code to
    add_template_candidate_real:
    +  /* Now the explicit specifier might have been deduced; check if this
    +     declaration is explicit.  If it is and we're ignoring non-convert=
ing
    +     constructors, don't add this function to the set of candidates.  =
*/
    +  if ((flags & LOOKUP_ONLYCONVERTING) && DECL_NONCONVERTING_P (fn))
    +    return NULL;
    but as this test demonstrates, that's incorrect when we're initializing
    from a {}: for list-initialization we consider explicit constructors and
    complain if one is chosen.

            PR c++/109159

    gcc/cp/ChangeLog:

            * call.cc (add_template_candidate_real): Add explicit decls to =
the
            set of candidates when the initializer is a braced-init-list.

    libstdc++-v3/ChangeLog:

            * testsuite/20_util/pair/cons/explicit_construct.cc: Adjust
dg-error.
            * testsuite/20_util/tuple/cons/explicit_construct.cc: Likewise.
            * testsuite/23_containers/span/explicit.cc: Likewise.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp0x/explicit16.C: New test.=