public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "nix at esperi dot org.uk" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug debug/109161] Bad CTF generated for stub in function scope Date: Tue, 28 Mar 2023 23:01:55 +0000 [thread overview] Message-ID: <bug-109161-4-Jud59S574E@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109161-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109161 Nix <nix at esperi dot org.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nix at esperi dot org.uk --- Comment #2 from Nix <nix at esperi dot org.uk> --- It definitely shouldn't hang for invalid input, but that sort of proof against invalid input isn't even implemented for the deduplicator yet, let alone every other thing that recurses over the type graph. It's on the todo list... and it's not specific to objdump at all: ctf_dump (objdump/readelf), ctf_type_rvisit, ctf_type_compat, even foundational libctf stuff like ctf_type_resolve would hang if, say, we had a CTF_K_CONST node pointing to itself, even indirectly. This does mean that anything we use to detect cycles must be *cheap*. Now I was assuming I could only implement cycle-detection efficiently for the deduplicator (which would usually suffice, since linking is the first thing that is usually done to compiler-generated CTF) -- but it occurs to me now that I could use a similar technique in ctf_type_rvisit, which will handle ctf_dump: I can probably do the same for the other recursive type-traversing functions, and handle all of them with the same cycle-detection code, and then CTF manipulation on raw object files would be safe against cycles too. The algorithm in question (one of Hellman's more obscure) cannot guarantee immediate detection of cycles, but it will always detect them eventually, which is good enough for this application. That's the price we pay for spotting cycles in constant space with almost no time overhead for the common, acyclic case.
next prev parent reply other threads:[~2023-03-28 23:01 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-16 20:45 [Bug debug/109161] New: " ibhagat at gcc dot gnu.org 2023-03-19 23:11 ` [Bug debug/109161] " pinskia at gcc dot gnu.org 2023-03-28 23:01 ` nix at esperi dot org.uk [this message] 2023-04-12 21:19 ` ibhagat at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109161-4-Jud59S574E@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).