From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 5AC8B3882643; Wed,  3 May 2023 15:22:54 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5AC8B3882643
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1683127374;
	bh=b5BUzTbT1isf6C+eTzIshTuaUtA+a1f4tRHW1hgwWKM=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=HyGUGGp6JraNX0V/RuN2shB14CM5rYaqjPkeFfBf2qovFitjhEExl1jD9aMsD5e/f
	 tigyLL7lpk9GchO6pyErEwe/UIelYInrwKFa25Zn3x7rsy60w9CxGWdlXuDbe+8gSX
	 pE3gGeQGjybvJj/IR6sfY+BPVdgtTvJXqPwxXtkI=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug c++/109164] wrong code with thread_local reference, loops and
 -ftree-pre
Date: Wed, 03 May 2023 15:22:53 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: c++
X-Bugzilla-Version: 12.1.0
X-Bugzilla-Keywords: wrong-code
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109164-4-0lpZBmFksx@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109164-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109164-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109164

--- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-10 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:73accd859e80e5d50937b8dc85a4e509fc174b97

commit r10-11381-g73accd859e80e5d50937b8dc85a4e509fc174b97
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Mar 20 20:29:47 2023 +0100

    c++: Drop TREE_READONLY on vars (possibly) initialized by tls wrapper
[PR109164]

    The following two testcases are miscompiled, because we keep TREE_READO=
NLY
    on the vars even when they are (possibly) dynamically initialized by a =
TLS
    wrapper function.  Normally cp_finish_decl drops TREE_READONLY from vars
    which need dynamic initialization, but for TLS we do this kind of
    initialization upon every access to those variables.  Keeping them
    TREE_READONLY means e.g. PRE can hoist loads from those before loops
    which contain the TLS wrapper calls, so we can access the TLS variables
    before they are initialized.

    2023-03-20  Jakub Jelinek  <jakub@redhat.com>

            PR c++/109164
            * cp-tree.h (var_needs_tls_wrapper): Declare.
            * decl2.c (var_needs_tls_wrapper): No longer static.
            * decl.c (cp_finish_decl): Clear TREE_READONLY on TLS variables
            for which a TLS wrapper will be needed.

            * g++.dg/tls/thread_local13.C: New test.
            * g++.dg/tls/thread_local13-aux.cc: New file.
            * g++.dg/tls/thread_local14.C: New test.
            * g++.dg/tls/thread_local14-aux.cc: New file.

    (cherry picked from commit 0a846340b99675d57fc2f2923a0412134eed09d3)=