public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug d/109231] [13 regression] Comparison failure in libphobos/libdruntime/rt/util/typeinfo.o Date: Wed, 29 Mar 2023 10:51:24 +0000 [thread overview] Message-ID: <bug-109231-4-KLEKTnf72J@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109231-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109231 --- Comment #23 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Ugh, that sounds like an uninitialized use of something somewhere, unfortunately if it is really my commit, I don't understand how it could cause it. All it changes is that when tree_versioning is called, the push_struct_function -> allocate_struct_function will not do the if (!abstract_p) { /* Now that we have activated any function-specific attributes that might affect layout, particularly vector modes, relayout each of the parameters and the result. */ relayout_decl (result); for (tree parm = DECL_ARGUMENTS (fndecl); parm; parm = DECL_CHAIN (parm)) relayout_decl (parm); } and if (!abstract_p && aggregate_value_p (result, fndecl)) { #ifdef PCC_STATIC_STRUCT_RETURN cfun->returns_pcc_struct = 1; #endif cfun->returns_struct = 1; } parts it did before when abstract_p was false in this case. As I wrote, initialize_cfun has cfun->returns_struct = src_cfun->returns_struct; cfun->returns_pcc_struct = src_cfun->returns_pcc_struct; a few lines later, so whatever it sets cfun->returns* to should be overritten quickly. It is true allocate_stack_function calls before that allocate_stack_usage_info and stdarg_p but neither of those two should care about those flag or whatever relayout_decl does. Perhaps try to undo my patch in a different way, like --- gcc/tree-inline.cc 2023-03-17 18:59:50.226199917 +0100 +++ gcc/tree-inline.cc 2023-03-29 12:47:21.546947442 +0200 @@ -2785,7 +2785,7 @@ initialize_cfun (tree new_fndecl, tree c gimple_register_cfg_hooks (); /* Get clean struct function. */ - push_struct_function (new_fndecl, true); + push_struct_function (new_fndecl, false); targetm.target_option.relayout_function (new_fndecl); /* We will rebuild these, so just sanity check that they are empty. */ or --- gcc/tree-inline.cc 2023-03-17 18:59:50.226199917 +0100 +++ gcc/tree-inline.cc 2023-03-29 12:49:16.580255668 +0200 @@ -2786,7 +2786,11 @@ initialize_cfun (tree new_fndecl, tree c /* Get clean struct function. */ push_struct_function (new_fndecl, true); + relayout_decl (DECL_RESULT (new_fndecl)); + for (tree parm = DECL_ARGUMENTS (new_fndecl); parm; parm = DECL_CHAIN (parm)) + relayout_decl (parm); targetm.target_option.relayout_function (new_fndecl); + aggregate_value_p (DECL_RESULT (new_fndecl), new_fndecl); /* We will rebuild these, so just sanity check that they are empty. */ gcc_assert (VALUE_HISTOGRAMS (cfun) == NULL); and see if that changes anything? Of course both of those patches break the PR105554 again. Or if the latter helps, try to comment out the different parts of it too. Seems there was some valgrind for SPARC Solaris out of tree, but can't find it anymore...
next prev parent reply other threads:[~2023-03-29 10:51 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-21 12:42 [Bug d/109231] New: " ro at gcc dot gnu.org 2023-03-21 12:42 ` [Bug d/109231] " ro at gcc dot gnu.org 2023-03-21 12:49 ` jakub at gcc dot gnu.org 2023-03-21 12:58 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-21 14:02 ` jakub at gcc dot gnu.org 2023-03-21 14:36 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-21 15:16 ` jakub at gcc dot gnu.org 2023-03-21 15:18 ` ro at gcc dot gnu.org 2023-03-21 15:37 ` jakub at gcc dot gnu.org 2023-03-21 16:21 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-22 6:51 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-22 13:29 ` jakub at gcc dot gnu.org 2023-03-22 14:01 ` jakub at gcc dot gnu.org 2023-03-22 16:12 ` jakub at gcc dot gnu.org 2023-03-22 16:55 ` jakub at gcc dot gnu.org 2023-03-22 17:03 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-22 21:31 ` jakub at gcc dot gnu.org 2023-03-23 9:16 ` jakub at gcc dot gnu.org 2023-03-23 12:18 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-23 12:28 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-23 12:32 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-24 12:40 ` jakub at gcc dot gnu.org 2023-03-24 13:08 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-29 8:53 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-29 10:51 ` jakub at gcc dot gnu.org [this message] 2023-03-29 15:00 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-29 15:08 ` jakub at gcc dot gnu.org 2023-03-29 15:11 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-29 15:13 ` jakub at gcc dot gnu.org 2023-03-30 13:30 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-30 13:44 ` jakub at gcc dot gnu.org 2023-03-30 16:22 ` jakub at gcc dot gnu.org 2023-03-30 18:17 ` jakub at gcc dot gnu.org 2023-03-31 7:57 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-31 7:59 ` jakub at gcc dot gnu.org 2023-03-31 9:22 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-31 9:26 ` jakub at gcc dot gnu.org 2023-03-31 12:15 ` ro at CeBiTec dot Uni-Bielefeld.DE 2023-03-31 12:28 ` jakub at gcc dot gnu.org 2023-04-17 15:14 ` [Bug d/109231] [13/14 " jakub at gcc dot gnu.org 2023-06-14 12:29 ` ro at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109231-4-KLEKTnf72J@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).