From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 296CC3858022; Wed, 22 Mar 2023 12:42:07 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 296CC3858022
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1679488927;
	bh=sCS8kC6dUUOlGl4Kkj4TA2SAXNC/OT9dt4KUqEXZ7Pw=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=of+YU+g/tX7OzmmgJF/wdy/OOtcify/6MIyYlojLi0aAnWmAVzM9vif1EDe2vq7r/
	 GMPZIDDLF+JkMvuG2vD1KU62+LTyszWRSCNbIUUiCm1r/C1nJHS+zsMcGFo7H6tkfc
	 ZYMw6NNTMSJW8nKbBkkv8Gf21l1D+jTbjwWlKDHU=
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug analyzer/109239] -Wanalyzer-deref-before-check seen on Linux
 kernel due to inlining with -fno-delete-null-pointer-checks
Date: Wed, 22 Mar 2023 12:42:06 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: analyzer
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: cvs-commit at gcc dot gnu.org
X-Bugzilla-Status: UNCONFIRMED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P3
X-Bugzilla-Assigned-To: dmalcolm at gcc dot gnu.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-109239-4-cUmXiGfu46@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109239-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109239-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109239

--- Comment #1 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalcolm@gcc.gnu.org>:

https://gcc.gnu.org/g:0c652ebbf79bd168766097f3ac4c1b3b79d68a43

commit r13-6800-g0c652ebbf79bd168766097f3ac4c1b3b79d68a43
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Wed Mar 22 08:40:34 2023 -0400

    analyzer: fix false +ves from -Wanalyzer-deref-before-check due to inli=
ning
[PR109239]

    The patch has this effect on my integration tests of -fanalyzer:

      Comparison:
        GOOD: 129        (17.70% -> 17.92%)
         BAD: 600 -> 591 (-9)

    which is purely due to improvements to -Wanalyzer-deref-before-check
    on the Linux kernel:

      -Wanalyzer-deref-before-check:
        GOOD: 1        (4.55% -> 7.69%)
         BAD: 21 -> 12 (-9)
         Known false positives: 16 -> 10 (-6)
           linux-5.10.162: 7 -> 1 (-6)
         Suspected false positives: 3 -> 0 (-3)
           linux-5.10.162: 3 -> 0 (-3)

    gcc/analyzer/ChangeLog:
            PR analyzer/109239
            * program-point.cc: Include "analyzer/inlining-iterator.h".
            (program_point::effectively_intraprocedural_p): New function.
            * program-point.h (program_point::effectively_intraprocedural_p=
):
            New decl.
            * sm-malloc.cc (deref_before_check::emit): Use it when rejecting
            interprocedural cases, so that we reject interprocedural cases
            that have become intraprocedural due to inlining.

    gcc/testsuite/ChangeLog:
            PR analyzer/109239
            * gcc.dg/analyzer/deref-before-check-pr109239-linux-bus.c: New
test.

    Signed-off-by: David Malcolm <dmalcolm@redhat.com>=