public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/109254] Bug in gcc (13.0.1) support for ARM SVE, which randomly modifies the prediction register
Date: Thu, 23 Mar 2023 16:08:05 +0000	[thread overview]
Message-ID: <bug-109254-4-lXUg0waHkx@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-109254-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109254

--- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
2023-03-23  Jakub Jelinek  <jakub@redhat.com>

        PR target/109254
        * config/aarch64/aarch64.cc (aarch64_function_arg_regno_p): Also
        return true for p0-p3.

--- gcc/config/aarch64/aarch64.cc.jj    2023-03-13 00:11:52.328213351 +0100
+++ gcc/config/aarch64/aarch64.cc       2023-03-23 16:57:29.957866005 +0100
@@ -7959,7 +7959,8 @@ bool
 aarch64_function_arg_regno_p (unsigned regno)
 {
   return ((GP_REGNUM_P (regno) && regno < R0_REGNUM + NUM_ARG_REGS)
-         || (FP_REGNUM_P (regno) && regno < V0_REGNUM + NUM_FP_ARG_REGS));
+         || (FP_REGNUM_P (regno) && regno < V0_REGNUM + NUM_FP_ARG_REGS)
+         || (PR_REGNUM_P (regno) && regno < P0_REGNUM + NUM_PR_ARG_REGS));
 }

 /* Implement FUNCTION_ARG_BOUNDARY.  Every parameter gets at least

fixes this.  Or do we want to return true for p0-p3 only if SVE is enabled?
Not familiar with SVE enough to turn the testcase into gcc.target/aarch64/sve
runtime tests (bet we need __attribute__((noipa)) on the function, but unsure
how to initialize the arguments in the caller and how to verify the result is
correct in it after the call.

  parent reply	other threads:[~2023-03-23 16:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-23  3:14 [Bug target/109254] New: " wumingchuan1992 at foxmail dot com
2023-03-23  3:23 ` [Bug target/109254] " pinskia at gcc dot gnu.org
2023-03-23 14:43 ` jakub at gcc dot gnu.org
2023-03-23 16:08 ` jakub at gcc dot gnu.org [this message]
2023-03-23 17:13 ` jakub at gcc dot gnu.org
2023-03-24 12:24 ` jakub at gcc dot gnu.org
2023-03-27  7:53 ` pinskia at gcc dot gnu.org
2023-04-01  6:58 ` cvs-commit at gcc dot gnu.org
2023-04-03 13:18 ` jakub at gcc dot gnu.org
2024-02-28  6:48 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-109254-4-lXUg0waHkx@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).