[Bug middle-end/109265] New: ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[Bug middle-end/109265] New: ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[stefansf at linux dot ibm.com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

            Bug ID: 109265
           Summary: ICE for 527.cam4_r after r13-6787-g0963cb5fde158c
           Product: gcc
           Version: unknown
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: stefansf at linux dot ibm.com
  Target Milestone: ---

$ gfortran -c -o sgexx.fppized.o -I. -Iinclude -Inetcdf/include -O3 -std=legacy
-fconvert=big-endian sgexx.F90
during GIMPLE pass: dom
sgexx.F90:8996:23:

 8996 |       SUBROUTINE SLAMC2( BETA, T, RND, EPS, EMIN, RMIN, EMAX, RMAX )
      |                       ^
internal compiler error: in in_chain_p, at gimple-range-gori.cc:119
0x24e31cf range_def_chain::in_chain_p(tree_node*, tree_node*)
        /devel/gcc/src/gcc/gimple-range-gori.cc:119
0x24e47e9 gori_compute::compute_operand_range(vrange&, gimple*, vrange const&,
tree_node*, fur_source&, value_relation*)
        /devel/gcc/src/gcc/gimple-range-gori.cc:667
0x24e5b47 gori_compute::compute_operand1_range(vrange&,
gimple_range_op_handler&, vrange const&, tree_node*, fur_source&,
value_relation*)
        /devel/gcc/src/gcc/gimple-range-gori.cc:1174
0x24e4739 gori_compute::compute_operand_range(vrange&, gimple*, vrange const&,
tree_node*, fur_source&, value_relation*)
        /devel/gcc/src/gcc/gimple-range-gori.cc:726
0x24e6505 gori_compute::compute_operand2_range(vrange&,
gimple_range_op_handler&, vrange const&, tree_node*, fur_source&,
value_relation*)
        /devel/gcc/src/gcc/gimple-range-gori.cc:1254
0x24e6a91 gori_compute::compute_operand1_and_operand2_range(vrange&,
gimple_range_op_handler&, vrange const&, tree_node*, fur_source&,
value_relation*)
        /devel/gcc/src/gcc/gimple-range-gori.cc:1274
0x24e4911 gori_compute::compute_operand_range(vrange&, gimple*, vrange const&,
tree_node*, fur_source&, value_relation*)
        /devel/gcc/src/gcc/gimple-range-gori.cc:723
0x24e8b75 gori_compute::outgoing_edge_range_p(vrange&, edge_def*, tree_node*,
range_query&)
        /devel/gcc/src/gcc/gimple-range-gori.cc:1384
0x24d71c5 ranger_cache::edge_range(vrange&, edge_def*, tree_node*,
ranger_cache::rfd_mode)
        /devel/gcc/src/gcc/gimple-range-cache.cc:964
0x24d732d ranger_cache::range_on_edge(vrange&, edge_def*, tree_node*)
        /devel/gcc/src/gcc/gimple-range-cache.cc:1001
0x24df129 fold_using_range::range_of_range_op(vrange&,
gimple_range_op_handler&, fur_source&)
        /devel/gcc/src/gcc/gimple-range-fold.cc:558
0x24e11c1 fold_using_range::fold_stmt(vrange&, gimple*, fur_source&,
tree_node*)
        /devel/gcc/src/gcc/gimple-range-fold.cc:489
0x24e171d fold_range(vrange&, gimple*, edge_def*, range_query*)
        /devel/gcc/src/gcc/gimple-range-fold.cc:326
0x24e8e03 gori_compute::outgoing_edge_range_p(vrange&, edge_def*, tree_node*,
range_query&)
        /devel/gcc/src/gcc/gimple-range-gori.cc:1411
0x24d6c55 ranger_cache::range_from_dom(vrange&, tree_node*, basic_block_def*,
ranger_cache::rfd_mode)
        /devel/gcc/src/gcc/gimple-range-cache.cc:1524
0x24d8e9b ranger_cache::range_from_dom(vrange&, tree_node*, basic_block_def*,
ranger_cache::rfd_mode)
        /devel/gcc/src/gcc/gimple-range-cache.cc:1421
0x24d8e9b ranger_cache::fill_block_cache(tree_node*, basic_block_def*,
basic_block_def*)
        /devel/gcc/src/gcc/gimple-range-cache.cc:1212
0x24d9d2f ranger_cache::block_range(vrange&, basic_block_def*, tree_node*,
bool)
        /devel/gcc/src/gcc/gimple-range-cache.cc:1039
0x24cedc9 gimple_ranger::range_on_entry(vrange&, basic_block_def*, tree_node*)
        /devel/gcc/src/gcc/gimple-range.cc:156
0x24d23b3 gimple_ranger::range_of_expr(vrange&, tree_node*, gimple*)
        /devel/gcc/src/gcc/gimple-range.cc:130
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

Started after r13-6787-g0963cb5fde158c

I have no experience with reducing a Fortran program. Is there an equivalent
way of -E for gfortran? Reducing via delta results in dependencies like

    9 | use shr_kind_mod,    only: r8 => shr_kind_r8
      |     1
Fatal Error: Cannot open module file 'shr_kind_mod.mod' for reading at (1): No
such file or directory
compilation terminated.

Currently I circumvent those errors by copying modules into my temp directory
but of course in the end I cannot upload those modules.

[Bug middle-end/109265] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I think one way is to include all the needed modules by hand into the same
*.f90 source
(for each module, find in which source file it is defined and copy the module
... end module stuff) and repeat until you have it all.
Another one is try multi-file delta or the script from
https://gcc.gnu.org/wiki/A_guide_to_testcase_reduction

[Bug middle-end/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ICE for 527.cam4_r after    |[13 Regression] ICE for
                   |r13-6787-g0963cb5fde158c    |527.cam4_r after
                   |                            |r13-6787-g0963cb5fde158c
           Keywords|                            |ice-on-valid-code,
                   |                            |needs-reduction
   Target Milestone|---                         |13.0

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unknown                     |13.0
          Component|middle-end                  |tree-optimization

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Btw, cannot reproduce on x86_64, but this might be the DOM pass after
vectorizing / loop optimizing and s390 adjusts some --param defaults that
affect unrolling for example.

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Note it's probably enough to print what 'name' is on the failing assert and
maybe dump some context on the stmt we are processing.

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

Martin Liška <marxin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-03-24

--- Comment #4 from Martin Liška <marxin at gcc dot gnu.org> ---
I've got a self-contained test-case, reducing right now..

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[marxin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

--- Comment #5 from Martin Liška <marxin at gcc dot gnu.org> ---
Created attachment 54740
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=54740&action=edit
Reduced test-case

s390x-linux-gnu-gcc sgexx.F90 -c -O3
during GIMPLE pass: dom
sgexx.F90:14:23:

   14 |       SUBROUTINE SLAMC2( BETA, T, RND, EPS, EMIN, RMIN, EMAX, RMAX )
      |                       ^
internal compiler error: Segmentation fault
0xc36fbf crash_signal
        /buildworker/marxinbox-gcc-trunk-s390x/build/gcc/toplev.cc:314
0x1459624 range_def_chain::in_chain_p(tree_node*, tree_node*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-gori.cc:126
0x1459624 gori_compute::compute_operand_range(vrange&, gimple*, vrange const&,
tree_node*, fur_source&, value_relation*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-gori.cc:667
0x145a437 gori_compute::compute_operand1_range(vrange&,
gimple_range_op_handler&, vrange const&, tree_node*, fur_source&,
value_relation*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-gori.cc:1174
0x14594c5 gori_compute::compute_operand_range(vrange&, gimple*, vrange const&,
tree_node*, fur_source&, value_relation*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-gori.cc:726
0x145ac07 gori_compute::compute_operand2_range(vrange&,
gimple_range_op_handler&, vrange const&, tree_node*, fur_source&,
value_relation*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-gori.cc:1254
0x145b054 gori_compute::compute_operand1_and_operand2_range(vrange&,
gimple_range_op_handler&, vrange const&, tree_node*, fur_source&,
value_relation*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-gori.cc:1274
0x1459402 gori_compute::compute_operand_range(vrange&, gimple*, vrange const&,
tree_node*, fur_source&, value_relation*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-gori.cc:723
0x145c7c8 gori_compute::outgoing_edge_range_p(vrange&, edge_def*, tree_node*,
range_query&)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-gori.cc:1384
0x144f319 ranger_cache::edge_range(vrange&, edge_def*, tree_node*,
ranger_cache::rfd_mode)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-cache.cc:964
0x144e86f ranger_cache::resolve_dom(vrange&, tree_node*, basic_block_def*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-cache.cc:1407
0x144ee30 ranger_cache::range_from_dom(vrange&, tree_node*, basic_block_def*,
ranger_cache::rfd_mode)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-cache.cc:1518
0x145087f ranger_cache::range_from_dom(vrange&, tree_node*, basic_block_def*,
ranger_cache::rfd_mode)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-cache.cc:1421
0x145087f ranger_cache::fill_block_cache(tree_node*, basic_block_def*,
basic_block_def*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-cache.cc:1212
0x1451382 ranger_cache::block_range(vrange&, basic_block_def*, tree_node*,
bool)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-cache.cc:1039
0x1448ed1 gimple_ranger::range_on_entry(vrange&, basic_block_def*, tree_node*)
        /buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range.cc:156
0xda06d3 path_range_query::range_on_path_entry(vrange&, tree_node*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-path.cc:160
0xda06d3 path_range_query::internal_range_of_expr(vrange&, tree_node*, gimple*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-path.cc:176
0xda08a8 path_range_query::internal_range_of_expr(vrange&, tree_node*, gimple*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-path.cc:210
0xda08a8 path_range_query::range_of_expr(vrange&, tree_node*, gimple*)
       
/buildworker/marxinbox-gcc-trunk-s390x/build/gcc/gimple-range-path.cc:202
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

--- Comment #6 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Perhaps the same bug as PR109274?

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
Without USE:

module sgexx
    integer,parameter :: r8 = selected_real_kind(12) ! 8 byte real
contains
      SUBROUTINE SLACPY( UPLO, M, N, A, LDA, B, LDB )
      END SUBROUTINE SLACPY
      SUBROUTINE SLARFB( SIDE, TRANS, DIRECT, STOREV, M, N, K, V, LDV, &
                         T, LDT, C, LDC, WORK, LDWORK )
      REAL(r8)               C( LDC, * ), T( LDT, * ), V( LDV, * ), &
                         WORK( LDWORK, * )
      END SUBROUTINE SLARFB
      SUBROUTINE SLAMC2( BETA, T, RND, EPS, EMIN, RMIN, EMAX, RMAX )
      LOGICAL            FIRST, IEEE, IWARN, LIEEE1, LRND
      INTEGER            GNMIN, GPMIN, I, LBETA, LEMAX, LEMIN, LT, &
                         NGNMIN, NGPMIN
      REAL(r8)               A, B, C, HALF, LEPS, LRMAX, LRMIN, ONE, RBASE, &
                         SIXTH, SMALL, THIRD, TWO, ZERO
      IF( FIRST ) THEN
            SMALL = SLAMC3( SMALL*RBASE, ZERO )
         A = SLAMC3( ONE, SMALL )
         CALL SLAMC4( GPMIN, A, LBETA )
         CALL SLAMC4( GNMIN, -A, LBETA )
      END IF
      END SUBROUTINE SLAMC2
      FUNCTION SLAMC3( A, B )
      real(r8) slamc3
      REAL(r8)               A, B
      SLAMC3 = A + B
      END FUNCTION SLAMC3
      SUBROUTINE SLAMC4( EMIN, START, BASE )
      INTEGER            BASE, EMIN
      REAL(r8)               START
      REAL(r8)               A, B1, B2, C1, C2, D1, D2, ONE, RBASE, ZERO
      A = START
      ZERO = 0
      C1 = A
      C2 = A
      D1 = A
   10 CONTINUE
      IF( ( C1.EQ.A ) .AND. ( C2.EQ.A ) .AND. ( D1.EQ.A ) .AND. &
          ( D2.EQ.A ) ) THEN
         D2 = ZERO
         GO TO 10
      END IF
      END SUBROUTINE SLAMC4
      SUBROUTINE SGEMV ( TRANS, M, N, ALPHA, A, LDA, X, INCX, &
                         BETA, Y, INCY )
      END SUBROUTINE SGEMV
      SUBROUTINE STRMM ( SIDE, UPLO, TRANSA, DIAG, M, N, ALPHA, A, LDA, &
                         B, LDB )
      END SUBROUTINE STRMM
end module sgexx

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

--- Comment #8 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
My PR109274 patch fixes this too.

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

--- Comment #9 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Adjusted testcase:
module pr109265
  integer, parameter :: r8 = selected_real_kind (12)
contains
  subroutine foo (b, c, d, e, f)
    implicit none
    logical :: b
    real (kind = r8) :: c, d, e, f, i
    if (b) then
      c = bar (c * d, e)
      i = bar (f, c)
      call baz (i)
      call baz (-i)
    end if
  end subroutine foo
  function bar (a, b)
    implicit none
    real (kind = r8) :: bar
    real (kind = r8) :: a, b
    bar = a + b
  end function bar
  subroutine baz (b)
    implicit none
    real (kind = r8) :: b, d, e, f, g, h, i
    d = b
    i = 0
    e = d
    f = d
    g = d
  10 continue
    if ((e.eq.d) .and. (f.eq.d) .and. (g.eq.d) .and. (h.eq.d)) then
      h = i
      go to 10
    end if
  end subroutine baz
end module pr109265

It uses one uninitialized variable (h, D2 in the above one; but we shouldn't
ICE on it).

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #10 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Dup.

*** This bug has been marked as a duplicate of bug 109274 ***

[Bug tree-optimization/109265] [13 Regression] ICE for 527.cam4_r after r13-6787-g0963cb5fde158c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109265

--- Comment #11 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andrew Macleod <amacleod@gcc.gnu.org>:

https://gcc.gnu.org/g:dd63bba0c8dc3a6ae06cfdc084bca7c68b8bbd39

commit r13-6906-gdd63bba0c8dc3a6ae06cfdc084bca7c68b8bbd39
Author: Andrew MacLeod <amacleod@redhat.com>
Date:   Fri Mar 24 11:21:20 2023 -0400

    Fix compute_operand when op1 == op2 symbolically.

    First, class value_relation should not sanitize records. just create
    what is asked.

    Second., if there is not a relation record, compute_operand was
    creating one for op1 == op2 if op1 and op2 were the same symbol.   This
    is not the correct way to communicate the information, as that record
    will continue to be passed along the GORI unwind chain.

    Instead, simply pass that information locally to the opX_range routine
    for only the current statement.

            PR tree-optimization/109265
            PR tree-optimization/109274
            gcc/
            * gimple-range-gori.cc (gori_compute::compute_operand_range): Do
            not create a relation record is op1 and op2 are the same symbol.
            (gori_compute::compute_operand1_range): Pass op1 == op2 to the
            handler for this stmt, but create a new record only if this
statement
            generates a relation based on the ranges.
            (gori_compute::compute_operand2_range): Ditto.
            * value-relation.h (value_relation::set_relation): Always create
the
            record that is requested.

            gcc/testsuite/
            * gcc.dg/pr109274.c: New.
            * gfortran.dg/pr109265.f90: New.