From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-bugzilla@gcc.gnu.org>
Received: by sourceware.org (Postfix, from userid 48)
	id 626313858431; Fri, 24 Mar 2023 15:02:24 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 626313858431
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org;
	s=default; t=1679670144;
	bh=fp13CYf9QCsbI9j3tqI5VsynqMfASPLUnwpJbxecSUo=;
	h=From:To:Subject:Date:In-Reply-To:References:From;
	b=NbmPCY4TfmqblT18lExyk9lq7P2mDIe841JoXafAMHMMC9WYtRHi+ksRGAHe6A0eY
	 XDCy0VuCAP8qTdDISPNAmTCwP6Q7OJ2UGnJrP5RqgF5BtZWzO12KlzBRYvEcXxgdMA
	 XVSymwkKPSdtXV9AUqFHM/ByycGqwufr3lFRV4r0=
From: "amacleod at redhat dot com" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/109274] [13 Regression] ice in in_chain_p, at
 gimple-range-gori.cc:119 starting with r13-6787-g0963cb5fde158cce986
Date: Fri, 24 Mar 2023 15:02:23 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: gcc
X-Bugzilla-Component: tree-optimization
X-Bugzilla-Version: 13.0
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: amacleod at redhat dot com
X-Bugzilla-Status: ASSIGNED
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P1
X-Bugzilla-Assigned-To: jakub at gcc dot gnu.org
X-Bugzilla-Target-Milestone: 13.0
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created
Message-ID: <bug-109274-4-j5fs3M2nfD@http.gcc.gnu.org/bugzilla/>
In-Reply-To: <bug-109274-4@http.gcc.gnu.org/bugzilla/>
References: <bug-109274-4@http.gcc.gnu.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://gcc.gnu.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
List-Id: <gcc-bugs.sourceware.org>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D109274

Andrew Macleod <amacleod at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54742|0                           |1
        is obsolete|                            |

--- Comment #6 from Andrew Macleod <amacleod at redhat dot com> ---
Created attachment 54743
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=3D54743&action=3Dedit
new patch

Before floating point relations were added, we tried to sanitize=20
value-relation records to not include non-sensensical records... ie=20
x !=3D x or x < x.   Instead, we made a VREL_VARYING record with no=20
operands.=20

When floating point relations were supported, some of these were no=20
longer non-sensical, AND we expanded the use of value_relation records=20
into GORI.=20

As a result, this sanitization is no longer needed.  The Oracle=20
does not create records with op1 =3D=3D op2, so its only within GORI=20
that these records can exist, and we shouldn't try to interpret them.=20

The bug occurs because the "sanitized" records doesn't set op1 and op2, and
changes the relation to VARYING..  and we have a record so expected the
operands it to be set the way they were just set.

We should not be setting a VREL_VARYING record if asked to set something el=
se.=