public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug other/109293] [12 Regression] Missing memmem() prototype in fixincludes/fixfixes.c on Windows/MinGW-W64 Date: Tue, 28 Mar 2023 10:01:20 +0000 [thread overview] Message-ID: <bug-109293-4-RqLvnQAIuH@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-109293-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109293 --- Comment #10 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The releases/gcc-12 branch has been updated by Xi Ruoyao <xry111@gcc.gnu.org>: https://gcc.gnu.org/g:743088c3c7c670f180978dd7b59a57fd9626c5a2 commit r12-9326-g743088c3c7c670f180978dd7b59a57fd9626c5a2 Author: Xi Ruoyao <xry111@xry111.site> Date: Tue Mar 28 01:48:02 2023 +0800 fixincludes: Declare memmem if it's not declared in system headers [PR109293] memmem is not POSIX so the system may lack it. Then libiberty will provide an implementation, but it's a "supplemental function" and not declared in libiberty.h. We need to declare the prototype to use it then. See libiberty doc at https://gcc.gnu.org/onlinedocs/libiberty/Supplemental-Functions.html. Tested by bootstrapping GCC in the following container environments on x86_64-linux-gnu: 1. "Vanilla" system with memmem in Glibc. 2. memmem removed from string.h. 3. memmem removed from both string.h and libc.so. For 3, also verified that memmem from libiberty is linked into fixincl executable. Note that the backport does not contain a complete regeneration of configure and config.h.in (attempting such regeneration resulted in all the USED_FOR_TARGET conditional disappearing; this already happened in trunk at r13-2200). fixincludes/ChangeLog: PR other/109293 * configure.ac (AC_CHECK_DECLS): Add memmem. * configure: Regenerate. * config.h.in: Regenerate. * system.h (memmem): Declare if HAVE_DECL_MEMMEM is zero. (cherry picked from commit 21c74b6ea41d21ef96813b34bfa55c51a82d6c99)
next prev parent reply other threads:[~2023-03-28 10:01 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-27 9:19 [Bug other/109293] New: " jdx at o2 dot pl 2023-03-27 15:42 ` [Bug other/109293] [12/13 Regression] " pinskia at gcc dot gnu.org 2023-03-27 16:02 ` xry111 at gcc dot gnu.org 2023-03-27 16:09 ` xry111 at gcc dot gnu.org 2023-03-27 16:13 ` pinskia at gcc dot gnu.org 2023-03-27 16:15 ` xry111 at gcc dot gnu.org 2023-03-27 16:19 ` pinskia at gcc dot gnu.org 2023-03-27 16:20 ` xry111 at gcc dot gnu.org 2023-03-28 7:26 ` cvs-commit at gcc dot gnu.org 2023-03-28 7:28 ` [Bug other/109293] [12 " xry111 at gcc dot gnu.org 2023-03-28 9:30 ` jdx at o2 dot pl 2023-03-28 10:01 ` cvs-commit at gcc dot gnu.org [this message] 2023-03-28 10:02 ` xry111 at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-109293-4-RqLvnQAIuH@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).